You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:08:39 UTC
[GitHub] [flink] twalthr opened a new pull request #14568: Update the Row.toString method
twalthr opened a new pull request #14568:
URL: https://github.com/apache/flink/pull/14568
## What is the purpose of the change
This updates the `Row.toString` method to provide a good summary string.
In particular it fixes the following issues:
- Changeflag: According to FLIP-95, a row describes an entry in a changelog. Therefore, it should visible whether a row is an insert, delete, or update change. Now indicated with `+I`, `-D`, `+U`, `-U`.
- Nested rows: In the old implementation it was not visible whether nested rows exist or not due to missing start/end boundaries. Now indicated with `[...]` or `{...}`.
- Positioned rows vs. named rows: According to FLIP-136, it should be visible whether a row operates in name-based or position-based field mode. Now indicated with `[...]` or `{...}`.
- Nested arrays in maps and lists: In the old implementation arrays in maps or lists could not be represented.
- Wrong formatting: Most programming languages use a space after a comma.
## Brief change log
Because this change might cause issues for tests, we provide a flag in `RowUtils` for legacy mode and a JUnit rule to make the migration incremental.
All tests in modules apart from the Blink planner/runtime module have been updated.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 372cd01838bb191f09961ee2dfa0d3b279c340bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: [FLINK-18090] Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
}, {
"hash" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695",
"triggerID" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"triggerType" : "PUSH"
}, {
"hash" : "7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11748",
"triggerID" : "7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695)
* 7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11748)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 372cd01838bb191f09961ee2dfa0d3b279c340bf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #14568: [FLINK-18090] Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #14568:
URL: https://github.com/apache/flink/pull/14568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
}, {
"hash" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 372cd01838bb191f09961ee2dfa0d3b279c340bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692)
* 7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 372cd01838bb191f09961ee2dfa0d3b279c340bf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #14568:
URL: https://github.com/apache/flink/pull/14568#discussion_r552652925
##########
File path: flink-core/src/main/java/org/apache/flink/types/RowUtils.java
##########
@@ -74,6 +74,8 @@ public static boolean compareRows(List<Row> l1, List<Row> l2, boolean ignoreOrde
// Internal utilities
// --------------------------------------------------------------------------------------------
+ public static boolean USE_LEGACY_TO_STRING = false;
Review comment:
Add a note it should be used only in tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: [FLINK-18090] Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755216198
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b (Fri May 28 07:02:10 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
}, {
"hash" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695",
"triggerID" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
}, {
"hash" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695",
"triggerID" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 372cd01838bb191f09961ee2dfa0d3b279c340bf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692)
* 7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14568: Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755216198
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 372cd01838bb191f09961ee2dfa0d3b279c340bf (Wed Jan 06 10:23:42 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14568: [FLINK-18090] Update the Row.toString method
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14568:
URL: https://github.com/apache/flink/pull/14568#issuecomment-755224268
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11692",
"triggerID" : "372cd01838bb191f09961ee2dfa0d3b279c340bf",
"triggerType" : "PUSH"
}, {
"hash" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695",
"triggerID" : "7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67",
"triggerType" : "PUSH"
}, {
"hash" : "7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ca6a4f3b85eff5e92c9b12d2fca2091abc6de67 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11695)
* 7b8a1e7046c2774fcb0d9fe282fb3ee5410d341b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org