You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "JANTON (JIRA)" <ji...@apache.org> on 2019/07/15 14:04:00 UTC
[jira] [Created] (HTTPCLIENT-2003) DefaultHostnameVerifier.verify
failled for host not ending with public suffix
JANTON created HTTPCLIENT-2003:
----------------------------------
Summary: DefaultHostnameVerifier.verify failled for host not ending with public suffix
Key: HTTPCLIENT-2003
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2003
Project: HttpComponents HttpClient
Issue Type: Bug
Affects Versions: 4.5.9
Reporter: JANTON
Hello,
The following use case *doesn't* work anymore with HttpClient *_4.5.9_* on DefaultHostnameVerifier (was ok with version _4.5.8_) :
_DefaultHostnameVerifier.verify(String, X509Certificate)_ return *+true+* when called with :
# a _host_ like "_a.b.c_"
# and a _certificate_ like "_CN=*.b.c_"
# and a _publicSuffixMatcher_ that +doesn't+ contain "_b.c_".
This could be highlighted by adding the flowing lines to _org.apache.http.conn.ssl.TestDefaultHostnameVerifier#testIdentityMatching()_ :
{code:java|title=org.apache.http.conn.ssl.TestDefaultHostnameVerifier#testIdentityMatching()}
Assert.assertTrue(DefaultHostnameVerifier.matchIdentity("a.b.c", "*.b.c", publicSuffixMatcher));
Assert.assertTrue(DefaultHostnameVerifier.matchIdentityStrict("a.b.c", "*.b.c", publicSuffixMatcher));
{code}
This change was introduced by HTTPCLIENT-1991. For me, it looks like an unintentional side effect. Could you please have a look.
Thank you very much for this great library.
Best regards
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org