[jira] [Resolved] (WICKET-1975) Allow custom form components to be more easily created by removing final from certain methods.

["Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-1975.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0

It seems org.apache.wicket.markup.html.form.FormComponent#setType(Class) lost 'final' from its signature at some point. Both 1.5.x and 6.x don't have 'final'.
                
> Allow custom form components to be more easily created by removing final from certain methods.
> ----------------------------------------------------------------------------------------------
>
>                 Key: WICKET-1975
>                 URL: https://issues.apache.org/jira/browse/WICKET-1975
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Larry Zappaterrini
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> I was perusing Wicket's Javadocs and I came across a link to an old thread: http://www.nabble.com/Why-add%28IBehavior%29-is-final--td7248198.html#a7248198
> The issue in that message thread was resolved by WICKET-94 with the final modifier being removed from from Component#add(IBehavior). I am currently trying to do something similar to the original author of the thread and I believe the same concession should be extended to FormComponent#add(IValidator) and FormComponent#setFieldType(Class<?>) due to similar arguments. In fact, might it make sense to look though the public final methods of FormComponent and only make final those that are absolutely necessary from an encapsulation standpoint?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira