You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/01/26 13:29:34 UTC
[jira] [Commented] (CB-8312) Multiply accelerometer values by -g on
Windows
[ https://issues.apache.org/jira/browse/CB-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291768#comment-14291768 ]
ASF GitHub Bot commented on CB-8312:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/24
CB-8312 Multiply accelerometer values by -g on Windows
This is a fix for [CB-8312](https://issues.apache.org/jira/browse/CB-8312)
The story: Windows implementation of device-motion methods returns acceleration, measrued in g's (source: https://msdn.microsoft.com/en-us/library/windows/apps/windows.devices.sensors.accelerometerreading.accelerationx). To be consistent with current plugin's specs, it is necessary to multiply accelerometer result by G constant (9.81 according to https://github.com/apache/cordova-plugin-device-motion/blob/master/doc/index.md#acceleration)
Also this PR contains additional commit https://github.com/MSOpenTech/cordova-plugin-device-motion/commit/213cd4b76519428484b78cb4292e0070c23d776d since the PR is based on git://git.apache.org/cordova-plugin-device-motion.git which is currently out of sync with https://github.com/apache/cordova-plugin-device-motion. This should correct the sync issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-8312
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-motion/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 213cd4b76519428484b78cb4292e0070c23d776d
Author: maria.bukharina <ma...@akvelon.com>
Date: 2014-11-27T16:14:12Z
CB-8096 Pended auto tests if accelerometer doesn't exist on the device
commit d9db216ed53b5b71a1304eba5c1b6274c04eff94
Author: daserge <da...@yandex.ru>
Date: 2015-01-15T10:00:32Z
CB-8312 Multiply accelerometer values by -g on Windows
----
> Multiply accelerometer values by -g on Windows
> ----------------------------------------------
>
> Key: CB-8312
> URL: https://issues.apache.org/jira/browse/CB-8312
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device Motion, Windows
> Reporter: Sergey Shakhnazarov
>
> Windows implementation of device-motion methods returns acceleration, measrued in g's (source: https://msdn.microsoft.com/en-us/library/windows/apps/windows.devices.sensors.accelerometerreading.accelerationx). To be consistent with current plugin's specs, it is necessary to multiply accelerometer result by G constant (9.81 according to https://github.com/apache/cordova-plugin-device-motion/blob/master/doc/index.md#acceleration)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org