You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:17:54 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1392: MINIFICPP-1900 Make the (Python part of the) script extension compile on Windows

fgerlits commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r948082000


##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
 #ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 #define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
 
+#undef COMPILER
+

Review Comment:
   TBH, I don't know why it's needed.  Something somewhere `#define`s `COMPILER` to the MSVC version, but I couldn't find what and where.
   
   I'll take another look and add the comment if I find out, but I didn't think `// something somewhere #defines COMPILE to the MSVC version on Windows` would be a useful comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org