You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2019/12/20 02:58:00 UTC
[jira] [Commented] (CASSANDRA-15460) Fix missing call to enable RPC
after native transport is started in in-jvm dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000572#comment-17000572 ]
Yifan Cai commented on CASSANDRA-15460:
---------------------------------------
Thanks [~drohrer]. The patch LGTM. +1
> Fix missing call to enable RPC after native transport is started in in-jvm dtests
> ---------------------------------------------------------------------------------
>
> Key: CASSANDRA-15460
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15460
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: Doug Rohrer
> Assignee: Doug Rohrer
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When starting the native transport, the original patch missed the step of calling {{StorageService.instance.setRpcReady(true);}}. This appears to only be required for counter columns, but without it you can't update a counter value.
> We should add this call after starting up the native transport, and set it to {{false}} during the shutdown sequence to mimic the production code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org