You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 09:31:44 UTC
[GitHub] [airflow] Junnplus opened a new pull request #13509: Fix extraVolumeMounts of scheduler
Junnplus opened a new pull request #13509:
URL: https://github.com/apache/airflow/pull/13509
Fix extraVolumeMounts position error if `Values.dags.gitSync.enabled` is True
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13509:
URL: https://github.com/apache/airflow/pull/13509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13509:
URL: https://github.com/apache/airflow/pull/13509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nikolayskovpin commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
nikolayskovpin commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-788107134
@kaxil @Junnplus I see the same issue for webserver. Can you confirm that it hasn't fixed for webserver yet?
It should be:
`
{{- if .Values.webserver.extraVolumes }}
{{ toYaml .Values.webserver.extraVolumes | indent 8 }}
{{- end }}
{{- if .Values.dags.gitSync.sshKeySecret }}
{{- include "git_sync_ssh_key_volume" . | indent 8 }}
{{- end }}
{{- end }}
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nikolayskovpin edited a comment on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
nikolayskovpin edited a comment on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-788107134
@kaxil @Junnplus I see the same issue for webserver. Can you confirm that it hasn't fixed for webserver yet?
It should be:
```
{{- if .Values.webserver.extraVolumes }}
{{ toYaml .Values.webserver.extraVolumes | indent 8 }}
{{- end }}
{{- if .Values.dags.gitSync.sshKeySecret }}
{{- include "git_sync_ssh_key_volume" . | indent 8 }}
{{- end }}
{{- end }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-755836003
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nikolayskovpin commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
nikolayskovpin commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-788699587
@Junnplus yeah, I do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nikolayskovpin edited a comment on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
nikolayskovpin edited a comment on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-788107134
@kaxil @Junnplus I see the same issue for webserver. Can you confirm that it hasn't been fixed for webserver yet?
It should be:
```
{{- if .Values.webserver.extraVolumes }}
{{ toYaml .Values.webserver.extraVolumes | indent 8 }}
{{- end }}
{{- if .Values.dags.gitSync.sshKeySecret }}
{{- include "git_sync_ssh_key_volume" . | indent 8 }}
{{- end }}
{{- end }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-789378818
@nikolayskovpin It's working for me. `webserver.extraVolumes` should be independent of `dags` values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nikolayskovpin commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
nikolayskovpin commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-789591811
@Junnplus thanks, I double checked. It was issue in my values.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Junnplus commented on pull request #13509: Fix extraVolumeMounts of scheduler
Posted by GitBox <gi...@apache.org>.
Junnplus commented on pull request #13509:
URL: https://github.com/apache/airflow/pull/13509#issuecomment-788555748
@nikolayskovpin Do you mean https://github.com/apache/airflow/blob/master/chart/templates/webserver/webserver-deployment.yaml#L178-L184 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org