[jira] [Work logged] (AMQ-8550) ActiveMQSslConnectionFactory: Check for null SSL Keystore and Truststore password

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-8550?focusedWorklogId=753010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753010 ]

ASF GitHub Bot logged work on AMQ-8550:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Apr/22 17:35
            Start Date: 05/Apr/22 17:35
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on PR #812:
URL: https://github.com/apache/activemq/pull/812#issuecomment-1089095138

   > LGTM. Good pick up to add the same check for keystore
   
   Thanks, even though the compilation is broken in Jenkins it worked for me so I'm going to go ahead and merge it. 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 753010)
    Time Spent: 20m  (was: 10m)

> ActiveMQSslConnectionFactory: Check for null SSL Keystore and Truststore password
> ---------------------------------------------------------------------------------
>
>                 Key: AMQ-8550
>                 URL: https://issues.apache.org/jira/browse/AMQ-8550
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>            Reporter: Andreas Gorges
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.17.1, 5.18.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When you assign a Truststore without a password the method {color:#000000}ActiveMQSslConnectionFactory.{color}{color:#00627a}createTrustManager throws a NullPointer exception in Line 135:
> {color}
>  
> {code:java}
> trustedCertStore.load(tsStream, trustStorePassword.toCharArray()); {code}
>  
> {color:#00627a}Please change the code to:{color}
> {code:java}
> char[] password = null;
> if (trustStorePassword != null) {
>      password = trustStorePassword.toCharArray();
> }
> trustedCertStore.load(tsStream, password);
>   {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)