You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/07/22 17:09:27 UTC
[GitHub] brooklyn-dist pull request #41: Do not merge, for review: Move karaf distrib...
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-dist/pull/41
Do not merge, for review: Move karaf distribution to brooklyn-dist.
This PR is the third of three that together move the karaf distribution to brooklyn-dist and separate out the software from brooklyn-library into separate catalog bom and feature files.
Merge this after https://github.com/apache/brooklyn-library/pull/53.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-dist move-karaf-to-dist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 11e181320beda48b01cb5d4b517ebebd88997c38
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-07-22T14:36:37Z
Move karaf distribution to brooklyn-dist.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #41: Do not merge, for review: Move karaf distrib...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/41#discussion_r72027266
--- Diff: dist-karaf/apache-brooklyn/src/main/resources/etc/default.catalog.bom ---
@@ -0,0 +1,371 @@
+
+# this catalog bom is an illustration supplying a few useful sample items
--- End diff --
Would be great if we could re-use the same `default.catalog.bom` when building classic and karaf distributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #41: Do not merge, for review: Move karaf distribution t...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-dist/pull/41
From the build log:
```
[WARNING] Some problems were encountered while building the effective model for org.apache.brooklyn:apache-brooklyn:karaf-assembly:0.10.0-SNAPSHOT
[WARNING] 'parent.relativePath' of POM org.apache.brooklyn:brooklyn-dist-karaf:[unknown-version] (/home/jenkins/jenkins-slave/workspace/brooklyn-dist-pull-requests/dist-karaf/pom.xml) points at org.apache.brooklyn:brooklyn-dist-root instead of org.apache.brooklyn:brooklyn-server, please verify your project structure @ org.apache.brooklyn:brooklyn-dist-karaf:[unknown-version], /home/jenkins/jenkins-slave/workspace/brooklyn-dist-pull-requests/dist-karaf/pom.xml, line 31, column 13
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #41: Do not merge, for review: Move karaf distrib...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/41#discussion_r72348289
--- Diff: dist-karaf/apache-brooklyn/src/main/resources/etc/default.catalog.bom ---
@@ -0,0 +1,371 @@
+
+# this catalog bom is an illustration supplying a few useful sample items
--- End diff --
I had a go at this and it turned out to be not entirely trivial - I think it would be worth doing this as a separate task, and not holding up this PR for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #41: Do not merge, for review: Move karaf distrib...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/41#discussion_r72027084
--- Diff: dist-karaf/apache-brooklyn/src/main/resources/etc/default.catalog.bom ---
@@ -0,0 +1,371 @@
+
+# this catalog bom is an illustration supplying a few useful sample items
+# and templates to get started using Brooklyn
+
+brooklyn.catalog:
+ version: "0.10.0-SNAPSHOT" # BROOKLYN_VERSION
+ items:
+ - brooklyn.libraries:
+ - name: org.apache.brooklyn.karaf-init
+ version: "0.10.0.SNAPSHOT" # BROOKLYN_VERSION
--- End diff --
Will cause rebind failure in upgrade, can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist pull request #41: Move karaf distribution to brooklyn-dist.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #41: Move karaf distribution to brooklyn-dist.
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-dist/pull/41
I've tested this - all seems to work
Tested compiling, running in amp and karaf
Checked entities available as expected in catalog
Ran some entities (mariadb crate)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-dist issue #41: Do not merge, for review: Move karaf distribution t...
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-dist/pull/41
Review comments applied except as noted above, squashed and pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---