You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/05 13:18:15 UTC
[GitHub] [dubbo-go] JiaLiangoooo opened a new issue #1044: registry simplified ignore user params
JiaLiangoooo opened a new issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044
**What happened**:
consul 只允许512个字符，provider必须要添加参数simplified：true，但是加入simplified会忽略自定义的参数
**What you expected to happen**:
simplified支持自定义参数
**How to reproduce it (as minimally and precisely as possible)**:
在config.load前，将service添加自定义的参数
**Anything else we need to know?**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #1044: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044#issuecomment-827391745
https://github.com/apache/dubbo-go/blob/3a9956a2a24c6736caae198b466a77ee979a5fd4/registry/protocol/protocol.go#L96-L102
In go version code, provider url will only reserve `reserveParams` if there is `simplified` keyword in registry url. This is the same as java version ([[1](https://github.com/apache/dubbo/blob/936c6624d3ce99cd05ebe03ede62dc671cf7b702/dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryProtocol.java#L405)], [[2](https://github.com/apache/dubbo/blob/936c6624d3ce99cd05ebe03ede62dc671cf7b702/dubbo-common/src/main/java/org/apache/dubbo/common/URL.java#L395-L402)]).
In my opinion:
- removing params, which is not reserved keyword, is by design
- the problem is that consul can not work without setting `simplified` keyword, because dubbo-go (or dubbo) register with too many parameters in registry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on issue #1044: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
cityiron commented on issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044#issuecomment-785642976
You can submit PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #1044: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044#issuecomment-821191900
@gaoxinge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #1044: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #1044: registry simplified ignore user params
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1044:
URL: https://github.com/apache/dubbo-go/issues/1044#issuecomment-868499370
we do not wanna support consul any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org