You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/08/15 05:30:04 UTC

[GitHub] [phoenix-omid] stoty commented on a diff in pull request #111: OMID-226 Migrate from mockito-all to mockito-core and clean up test dependencies

stoty commented on code in PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#discussion_r945433122


##########
pom.xml:
##########
@@ -168,7 +168,7 @@
         <protobuf.plugin.version>0.6.1</protobuf.plugin.version>
         <os.plugin.version>1.6.2</os.plugin.version>
         <junit.version>4.13.1</junit.version>
-        <mockito.version>1.10.19</mockito.version>
+        <mockito-core.version>2.28.2</mockito-core.version>

Review Comment:
   nit:
   AFAIK the mockito libraries have a single common version, we could keep using mockito.version as the property name, even if we only pull mockito-core.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org