You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/03/21 19:55:59 UTC
[PR] chore: Prepare for update to DataFusion 47 [datafusion-comet]
andygrove opened a new pull request, #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The next DataFusion release will be here in a few weeks. We should start getting ready.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2794672946
Some aggregate tests started to fail. I filed an issue in DataFusion https://github.com/apache/datafusion/issues/15676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Upgrade to datafusion 47.0.0-rc1 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "YanivKunda (via GitHub)" <gi...@apache.org>.
YanivKunda commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2817207648
> I'd like to merge this one and then switch to the official release next week
@andygrove here's the switch:
https://github.com/apache/datafusion-comet/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for datafusion 47.0.0 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2042171775
##########
native/core/src/execution/expressions/bloom_filter_might_contain.rs:
##########
@@ -140,4 +141,8 @@ impl PhysicalExpr for BloomFilterMightContain {
Arc::clone(&children[1]),
)?))
}
+
+ fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
+ unimplemented!()
+ }
Review Comment:
DataFusoin now supports a new EXPLAIN output, but this is not exposed in Comet, so we do not need to implement these new methods.
##########
native/core/src/execution/expressions/bloom_filter_might_contain.rs:
##########
@@ -140,4 +141,8 @@ impl PhysicalExpr for BloomFilterMightContain {
Arc::clone(&children[1]),
)?))
}
+
+ fn fmt_sql(&self, _: &mut Formatter<'_>) -> std::fmt::Result {
+ unimplemented!()
+ }
Review Comment:
DataFusion now supports a new EXPLAIN output, but this is not exposed in Comet, so we do not need to implement these new methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for datafusion 47.0.0 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2801995151
@comphead Could you review the HDFS changes? There was a change in objectstore to use `Range<u64>` instead of `Range<usize>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Upgrade to datafusion 47.0.0-rc1 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for datafusion 47.0.0 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2042173423
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -80,23 +82,33 @@ pub(crate) fn init_datasource_exec(
parquet_source = parquet_source.with_predicate(Arc::clone(data_schema), filter);
}
}
+
+ let file_groups = file_groups
+ .iter()
+ .map(|files| FileGroup::new(files.clone()))
+ .collect();
+
let file_scan_config = match (data_schema, projection_vector, partition_fields) {
- (Some(data_schema), Some(projection_vector), Some(partition_fields)) => get_file_config(
- data_schema,
- partition_schema,
- file_groups,
- object_store_url,
- Arc::new(parquet_source),
- )
- .with_projection(Some(projection_vector))
- .with_table_partition_cols(partition_fields),
- _ => get_file_config(
+ (Some(data_schema), Some(projection_vector), Some(partition_fields)) => {
+ get_file_config_builder(
Review Comment:
this now uses a builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2008287770
##########
native/core/src/parquet/schema_adapter.rs:
##########
@@ -216,57 +216,6 @@ impl SchemaMapper for SchemaMapping {
let record_batch = RecordBatch::try_new_with_options(schema, cols, &options)?;
Ok(record_batch)
}
-
- /// Adapts a [`RecordBatch`]'s schema into one that has all the correct output types and only
- /// contains the fields that exist in both the file schema and table schema.
- ///
- /// Unlike `map_batch` this method also preserves the columns that
- /// may not appear in the final output (`projected_table_schema`) but may
- /// appear in push down predicates
- fn map_partial_batch(&self, batch: RecordBatch) -> datafusion::common::Result<RecordBatch> {
Review Comment:
@mbutrovich @parthchandra fyi, I am not sure of the impact, but I figured I would first see if any tests fail in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for update to DataFusion 47 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2008245382
##########
native/core/src/parquet/schema_adapter.rs:
##########
@@ -216,57 +216,6 @@ impl SchemaMapper for SchemaMapping {
let record_batch = RecordBatch::try_new_with_options(schema, cols, &options)?;
Ok(record_batch)
}
-
- /// Adapts a [`RecordBatch`]'s schema into one that has all the correct output types and only
- /// contains the fields that exist in both the file schema and table schema.
- ///
- /// Unlike `map_batch` this method also preserves the columns that
- /// may not appear in the final output (`projected_table_schema`) but may
- /// appear in push down predicates
- fn map_partial_batch(&self, batch: RecordBatch) -> datafusion::common::Result<RecordBatch> {
Review Comment:
`map_partial_batch` has been removed in DataFusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2744428387
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1563?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 56.02%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e5e49d9`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/e5e49d96e99eaee42707ebed47106bb7aa829954?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 98 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1563 +/- ##
============================================
- Coverage 56.12% 56.02% -0.10%
+ Complexity 976 907 -69
============================================
Files 119 122 +3
Lines 11743 12208 +465
Branches 2251 2264 +13
============================================
+ Hits 6591 6840 +249
- Misses 4012 4253 +241
+ Partials 1140 1115 -25
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1563?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for datafusion 47.0.0 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2803327686
> @comphead Could you review the HDFS changes? There was a change in objectstore to use `Range<u64>` instead of `Range<usize>`
Thanks @andygrove I think these changes LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Upgrade to datafusion 47.0.0-rc1 and arrow-rs 55.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2810931660
I'd like to merge this one and then switch to the official release next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1563:
URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2784761501
I ran TPC-H benchmarks locally and do not see any noticeable difference in performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org