You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2005/04/26 19:18:09 UTC
Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Mark Phippard <Ma...@softlanding.com> writes:
> Doing some more testing I discovered this bug in JavaHL. In the method to
> return the lockCreationDate for an item it is instead returning the date
> of the last commit.
>
> Is it OK if I commit this to trunk?
>
> [[[
> Return correct date for lockCreationDate
>
> * bindings/javahl/src/org/tigris/subversion/javahl/Status.java
> Corrected the date field that was returned in getLockCreationDate()
> ]]]
>
> Index: javahl/src/org/tigris/subversion/javahl/Status.java
> ===================================================================
> --- javahl/src/org/tigris/subversion/javahl/Status.java (revision 14452)
> +++ javahl/src/org/tigris/subversion/javahl/Status.java (working copy)
> @@ -538,7 +538,7 @@
> if (lockCreationDate == 0)
> return null;
> else
> - return new Date(lastChangedDate / 1000);
> + return new Date(lockCreationDate / 1000);
> }
>
> /**
That seems like such an obvious cut-and-pasto (from line 246, to be
precise), that even though I don't know much about the JavaHL
bindings, I'm happy to +1 this and share the risk with you :-).
Go for it!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Who can vote was Re: [PATCH] JavaHL returns lastChangedDate
instead if lockCreationDate
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Wednesday, April 27, 2005 1:38 PM -0400 David James
<ja...@gmail.com> wrote:
> Would votes from non-committers who have tested and reviewed the patch
> with 1.2 be valuable?
Of course! Although for practical reasons, someone with commit access
would have to add their votes to STATUS. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Who can vote was Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by David James <ja...@gmail.com>.
> Well, anyone can vote. It's just that full committers or people with commit
> access to that area of the tree have their votes 'count' towards quorum.
>
> I think it's valuable for anyone (even a partial committer to a different
> area) to record their votes on backports if they have something to say about
> it.
Would votes from non-committers who have tested and reviewed the patch
with 1.2 be valuable?
Cheers,
David
--
http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Who can vote was Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by kf...@collab.net.
Justin Erenkrantz <ju...@erenkrantz.com> writes:
> > Anyone can nominate, only full committers can vote, that's all.
>
> Well, anyone can vote. It's just that full committers or people with commit
> access to that area of the tree have their votes 'count' towards quorum.
>
> I think it's valuable for anyone (even a partial committer to a different
> area) to record their votes on backports if they have something to say about
> it. It should, however, be made clear in the STATUS file that their vote is
> 'non-binding'. For example a notation like:
>
> +1: kfogel, pmayweg, full committers go here...
> +1 (non-binding): markphip
>
> My $.02. Not a big deal though. -- justin
I completely agree with you; that's really what I meant.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Who can vote was Re: [PATCH] JavaHL returns lastChangedDate instead if
lockCreationDate
Posted by Mark Phippard <Ma...@softlanding.com>.
Justin Erenkrantz <ju...@erenkrantz.com> wrote on 04/27/2005 12:38:33 PM:
> On Tue, Apr 26, 2005 at 04:02:59PM -0500, kfogel@collab.net wrote:
> > Mark Phippard <Ma...@softlanding.com> writes:
> > > I assume that only a full committer can nominate this in STATUS for
> > > backport to 1.2?
> >
> > Anyone can nominate, only full committers can vote, that's all.
>
> Well, anyone can vote. It's just that full committers or people with
commit
> access to that area of the tree have their votes 'count' towards quorum.
>
> I think it's valuable for anyone (even a partial committer to a
different
> area) to record their votes on backports if they have something to say
about
> it. It should, however, be made clear in the STATUS file that their
vote is
> 'non-binding'. For example a notation like:
>
> +1: kfogel, pmayweg, full committers go here...
> +1 (non-binding): markphip
>
> My $.02. Not a big deal though. -- justin
OK, thanks. I will not clutter the commits to add the vote this time, but
if I am in the position to nominate something in the future, I will add my
vote at the same time in the manner you describe.
Thanks
Mark
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Who can vote was Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Tue, Apr 26, 2005 at 04:02:59PM -0500, kfogel@collab.net wrote:
> Mark Phippard <Ma...@softlanding.com> writes:
> > I assume that only a full committer can nominate this in STATUS for
> > backport to 1.2?
>
> Anyone can nominate, only full committers can vote, that's all.
Well, anyone can vote. It's just that full committers or people with commit
access to that area of the tree have their votes 'count' towards quorum.
I think it's valuable for anyone (even a partial committer to a different
area) to record their votes on backports if they have something to say about
it. It should, however, be made clear in the STATUS file that their vote is
'non-binding'. For example a notation like:
+1: kfogel, pmayweg, full committers go here...
+1 (non-binding): markphip
My $.02. Not a big deal though. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by kf...@collab.net.
Mark Phippard <Ma...@softlanding.com> writes:
> I assume that only a full committer can nominate this in STATUS for
> backport to 1.2?
Anyone can nominate, only full committers can vote, that's all.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by Patrick Mayweg <ma...@qint.de>.
Hi Mark,
the patch is fine and please nominate for the 1.2 branch with my vote
+1. Since I am on the road, that difficult for me.
Patrick
Mark Phippard wrote:
>kfogel@newton.ch.collab.net wrote on 04/26/2005 03:18:09 PM:
>
>
>
>>That seems like such an obvious cut-and-pasto (from line 246, to be
>>precise), that even though I don't know much about the JavaHL
>>bindings, I'm happy to +1 this and share the risk with you :-).
>>
>>Go for it!
>>
>>
>
>Thanks. Committed r14454.
>
>I assume that only a full committer can nominate this in STATUS for
>backport to 1.2?
>
>I can work around this problem for the GA release, but it would be nice to
>have it in 1.2.1 or RC3 if there is one.
>
>Mark
>
>
>_____________________________________________________________________________
>Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
>_____________________________________________________________________________
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] JavaHL returns lastChangedDate instead if lockCreationDate
Posted by Mark Phippard <Ma...@softlanding.com>.
kfogel@newton.ch.collab.net wrote on 04/26/2005 03:18:09 PM:
> That seems like such an obvious cut-and-pasto (from line 246, to be
> precise), that even though I don't know much about the JavaHL
> bindings, I'm happy to +1 this and share the risk with you :-).
>
> Go for it!
Thanks. Committed r14454.
I assume that only a full committer can nominate this in STATUS for
backport to 1.2?
I can work around this problem for the GA release, but it would be nice to
have it in 1.2.1 or RC3 if there is one.
Mark
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org