[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1756: chore: update setup script

[GitBox <gi...@apache.org>]

bisakhmondal commented on pull request #1756:
URL: https://github.com/apache/apisix-dashboard/pull/1756#issuecomment-818605230


   > @bisakhmondal we should keep this script, we nee to download the Dockerfile when we need to test with APISIX master branch.
   
   Hiii. Okay, sounds good. One thing I'd like to address i.e. the compose file has been changed, so if we want to build the apisix image from the downloaded dockerfile, we have to manually update the compose file (just for the testing and again put it back to the original).
   
   As a hack, I think we can do something like `./setup.sh up --afresh` (--afresh an extra flag) which will 
   1. Download the dockerfile
   2. retag the already present `apache/apisix:2.4-alpine:latest` to `apache/apisix:2.4-alpine:stable`
   3. Build an image from the docker file with tag `apache/apisix:2.4-alpine:latest`
   
   A kind of abstraction that doesn't require altering the compose file. When we run `./setup.sh down`, it will revert the steps. 
   
   How does it sound to you :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org