You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/10/25 02:58:14 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #543: ORC-663: [C++] Support timestamp statistics with nanosecond

dongjoon-hyun commented on a change in pull request #543:
URL: https://github.com/apache/orc/pull/543#discussion_r511539389



##########
File path: c++/src/sargs/PredicateLeaf.cc
##########
@@ -510,6 +510,7 @@ namespace orc {
         break;
       }
       case PredicateDataType::STRING: {
+        ///FIXME: check lowerBound and upperBound as well

Review comment:
       Is this `TODO` item?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org