You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@apache.org> on 2006/02/08 00:48:53 UTC
Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have
extra carriage-return when generated on Windows.
El mié, 08-02-2006 a las 09:19 +1100, David Crossley escribió:
> Would you please explain what you mean.
>
> -David
>
> Thorsten Scherler (JIRA) wrote:
> > [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ]
> >
> > Thorsten Scherler commented on FOR-805:
> > ---------------------------------------
> >
> > <map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
> > <encoding>UTF-8</encoding>
> > </map:serializer>
> >
> > Maybe that is the reason for the additional \r
The above is taken from our main sitemap. Now in the resources.xmap that
is actually handling the final transformation in css you can find:
<map:serializer name="text" mime-type="text/plain"
src="org.apache.cocoon.serialization.TextSerializer"/>
¡Without! encoding. What I suggest is to add the encoding as well to the
resource.xmap to see whether that makes the difference (I have the
feeling that the whole issue could be based on encoding problems).
> >
> > > The build/site/skin/*.css have extra carriage-return when generated on Windows.
> > > -------------------------------------------------------------------------------
> > >
> > > Key: FOR-805
> > > URL: http://issues.apache.org/jira/browse/FOR-805
> > > Project: Forrest
> > > Type: Bug
> > > Components: Core operations
> > > Versions: 0.7
> > > Reporter: David Crossley
> >
> > >
> > > For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'
Further I am not sure that skin/basic.css is actually generated by the
the forrest bot since we copy the whole skin dir in the build target to
the project build/site.
It would be very interesting to know whether the skin/basic.css from
forrest site and forrest run have the same problem.
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.
Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
>
> Further I am not sure that skin/basic.css is actually generated by the
> the forrest bot since we copy the whole skin dir in the build target to
> the project build/site.
Yes it does: main/webapp/resources.xmap line 139
it has the Chaperon pattern transformer look for links.
> It would be very interesting to know whether the skin/basic.css from
> forrest site and forrest run have the same problem.
Jean attached the files to
http://issues.apache.org/jira/browse/FOR-805
Both files are the same.
-David
Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra
carriage-return when generated on Windows.
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Thorsten Scherler wrote:
> ...
> Further I am not sure that skin/basic.css is actually generated by the
> the forrest bot since we copy the whole skin dir in the build target to
> the project build/site.
>
> It would be very interesting to know whether the skin/basic.css from
> forrest site and forrest run have the same problem.
>
I did 'forrest run', but only find one copy of basic.css:
C:\jta\Apache\incubator>find . -name basic.css -print
./site-publish/skin/basic.css
should I be looking somewhere else?
-jean
p.s. I left an old svn snapshot of the incubator site in place for
anyone wondering.
Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra
carriage-return when generated on Windows.
Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Thorsten Scherler wrote:
> El mié, 08-02-2006 a las 09:19 +1100, David Crossley escribió:
>
>>Would you please explain what you mean.
>>
>>-David
>>
>>Thorsten Scherler (JIRA) wrote:
>>
>>> [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ]
>>>
>>>Thorsten Scherler commented on FOR-805:
>>>---------------------------------------
>>>
>>><map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
>>> <encoding>UTF-8</encoding>
>>> </map:serializer>
>>>
>>>Maybe that is the reason for the additional \r
>
> The above is taken from our main sitemap. Now in the resources.xmap that
> is actually handling the final transformation in css you can find:
> <map:serializer name="text" mime-type="text/plain"
> src="org.apache.cocoon.serialization.TextSerializer"/>
>
> ¡Without! encoding. What I suggest is to add the encoding as well to the
> resource.xmap to see whether that makes the difference (I have the
> feeling that the whole issue could be based on encoding problems).
I tried adding the encoding to main/webapp/resources.xmap, but the
'forrest run' basic.css and 'forrest site' basic.css still have the
additional \r's.
However, perhaps I don't understood what to change and where. Here's
what I tried:
C:\jta\Apache\forrest_07_branch\main\webapp>svn diff resources.xmap
Index: resources.xmap
===================================================================
--- resources.xmap (revision 372002)
+++ resources.xmap (working copy)
@@ -47,7 +47,10 @@
<!-- <parameter name="gamma" type="float" value="0.48"/> -->
<parameter name="gamma" type="float" value="0"/>
</map:serializer>
- <map:serializer name="text" mime-type="text/plain"
src="org.apache.cocoon.serialization.TextSerializer"/>
+ <map:serializer name="text" mime-type="text/plain"
src="org.apache.cocoon.serialization.TextSerializer">
+ <encoding>UTF-8</encoding>
+ </map:serializer>
+
</map:serializers>
<map:transformers default="xslt">
<map:transformer name="pattern"
regards,
-jean