You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 11:16:40 UTC
[GitHub] [airflow] ashb opened a new pull request, #25507: Remove Smart Sensors
ashb opened a new pull request, #25507:
URL: https://github.com/apache/airflow/pull/25507
It was deprecated in 2.3 and since it is experimental we can now remove
it -- Deferrable operators is a much more efficient pattern to achieve
the same feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a diff in pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
ashb commented on code in PR #25507:
URL: https://github.com/apache/airflow/pull/25507#discussion_r937535971
##########
newsfragments/25507.rst:
##########
@@ -0,0 +1,3 @@
+Removal of experimental Smart Sensors
+
+Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
Review Comment:
My other question about newsfragments if we should have any formatting in them (lists, headings etc?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25507:
URL: https://github.com/apache/airflow/pull/25507#discussion_r937871199
##########
newsfragments/25507.rst:
##########
@@ -0,0 +1,3 @@
+Removal of experimental Smart Sensors
+
+Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
Review Comment:
"should", no. "can", for significant yep!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25507:
URL: https://github.com/apache/airflow/pull/25507#discussion_r937875546
##########
newsfragments/25507.rst:
##########
@@ -0,0 +1,3 @@
+Removal of experimental Smart Sensors
+
+Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
Review Comment:
A little longer answer: Non-significant can only have a single line. Significant can be a single line, or multi-line rst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
ashb merged PR #25507:
URL: https://github.com/apache/airflow/pull/25507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25507:
URL: https://github.com/apache/airflow/pull/25507#discussion_r937932806
##########
newsfragments/25507.rst:
##########
@@ -0,0 +1,3 @@
+Removal of experimental Smart Sensors
+
+Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
Review Comment:
PR to improve the precommit: #25536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25507: Remove Smart Sensors
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #25507:
URL: https://github.com/apache/airflow/pull/25507#discussion_r936750697
##########
newsfragments/25507.rst:
##########
@@ -0,0 +1,3 @@
+Removal of experimental Smart Sensors
+
+Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
Review Comment:
```suggestion
Smart Sensors were added in 2.0 and deprecated in favour of Deferable operators in 2.2 and have now been removed.
```
(nit)
This should also be `25507.significant.rst`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org