You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/31 04:42:27 UTC

[GitHub] jerrypeng commented on issue #3477: Fixed the behavior of Function start/stop

jerrypeng commented on issue #3477: Fixed the behavior of Function start/stop
URL: https://github.com/apache/pulsar/pull/3477#issuecomment-459213086
 
 
   Mostly looks good.  I think we can also modify the following logic to check the function instance state so that we don't have that race condition:
   
   https://github.com/apache/pulsar/blob/master/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java#L647

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services