You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2017/05/20 11:36:18 UTC

[couchdb] 02/03: Revert "chore: more robust test"

This is an automated email from the ASF dual-hosted git repository.

jan pushed a commit to branch 3406/improve-tests
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 701fdaf85c3087daae9f3b6d48677aaed8dcbe78
Author: Jan Lehnardt <ja...@apache.org>
AuthorDate: Sat May 20 13:05:09 2017 +0200

    Revert "chore: more robust test"
    
    This reverts commit 059cb977ae286682b6c7b45846e3a1a14e13d5c9.
---
 .../test/couch_replicator_compact_tests.erl        | 34 ++++++++++------------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/src/couch_replicator/test/couch_replicator_compact_tests.erl b/src/couch_replicator/test/couch_replicator_compact_tests.erl
index 6c6b977..3e6bb9e 100644
--- a/src/couch_replicator/test/couch_replicator_compact_tests.erl
+++ b/src/couch_replicator/test/couch_replicator_compact_tests.erl
@@ -113,24 +113,22 @@ check_active_tasks(RepPid, {BaseId, Ext} = RepId, Src, Tgt) ->
     FullRepId = ?l2b(BaseId ++ Ext),
     Pid = ?l2b(pid_to_list(RepPid)),
     ok = wait_for_replicator(RepId),
-    case couch_task_status:all() of
-        [] -> ?assert(true);
-        [RepTask] ->
-            ?assertEqual(Pid, couch_util:get_value(pid, RepTask)),
-            ?assertEqual(FullRepId, couch_util:get_value(replication_id, RepTask)),
-            ?assertEqual(true, couch_util:get_value(continuous, RepTask)),
-            ?assertEqual(Source, couch_util:get_value(source, RepTask)),
-            ?assertEqual(Target, couch_util:get_value(target, RepTask)),
-            ?assert(is_integer(couch_util:get_value(docs_read, RepTask))),
-            ?assert(is_integer(couch_util:get_value(docs_written, RepTask))),
-            ?assert(is_integer(couch_util:get_value(doc_write_failures, RepTask))),
-            ?assert(is_integer(couch_util:get_value(revisions_checked, RepTask))),
-            ?assert(is_integer(couch_util:get_value(missing_revisions_found, RepTask))),
-            ?assert(is_integer(couch_util:get_value(checkpointed_source_seq, RepTask))),
-            ?assert(is_integer(couch_util:get_value(source_seq, RepTask))),
-            Pending = couch_util:get_value(changes_pending, RepTask),
-            ?assert(is_integer(Pending))
-    end.
+    [RepTask] = couch_task_status:all(),
+    ?assertEqual(Pid, couch_util:get_value(pid, RepTask)),
+    ?assertEqual(FullRepId, couch_util:get_value(replication_id, RepTask)),
+    ?assertEqual(true, couch_util:get_value(continuous, RepTask)),
+    ?assertEqual(Source, couch_util:get_value(source, RepTask)),
+    ?assertEqual(Target, couch_util:get_value(target, RepTask)),
+    ?assert(is_integer(couch_util:get_value(docs_read, RepTask))),
+    ?assert(is_integer(couch_util:get_value(docs_written, RepTask))),
+    ?assert(is_integer(couch_util:get_value(doc_write_failures, RepTask))),
+    ?assert(is_integer(couch_util:get_value(revisions_checked, RepTask))),
+    ?assert(is_integer(couch_util:get_value(missing_revisions_found, RepTask))),
+    ?assert(is_integer(couch_util:get_value(checkpointed_source_seq, RepTask))),
+    ?assert(is_integer(couch_util:get_value(source_seq, RepTask))),
+    Pending = couch_util:get_value(changes_pending, RepTask),
+    ?assert(is_integer(Pending)).
+
 
 rep_details(RepId) ->
     gen_server:call(get_pid(RepId), get_details).

-- 
To stop receiving notification emails like this one, please contact
"commits@couchdb.apache.org" <co...@couchdb.apache.org>.