[GitHub] [netbeans] eirikbakke commented on pull request #5336: Don't show the '+' separator in keyboard accelerators on MacOS

["eirikbakke (via GitHub)" <gi...@apache.org>]

eirikbakke commented on PR #5336:
URL: https://github.com/apache/netbeans/pull/5336#issuecomment-1484238035

   Thanks for these comments! I have pushed an improved version of this PR now, which gathers the required logic in a single new public API method Actions.keyStrokeToString, and uses it in more places. This includes the editor toolbar tooltips.
   
   In the Keymap settings code, changing accelerator strings is a bit risky, since there may be parsing code that assumes the old format. So I've left the options.keymap module untouched for now.
   
   There are also a few other places calling KeyEvent.getKeyText/getKeyModifiersText where presentation strings are generated in more complicated ways; I have left these for future work.
   
   > KeyEvent.getKeyModifiersText() and InputEvent.getModifiersExText() on macOS have the problem that the order of the modifier symbols is different to the order used by macOS
   
   Fixed, by using logic similar to the one you linked to in FlatLAF.
   
   > BTW would suggest to replace deprecated KeyEvent.getKeyModifiersText() with InputEvent.getModifiersExText().
   
   Done.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists