You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2023/01/17 09:08:55 UTC
[GitHub] [fineract] adamsaghy opened a new pull request, #2889: FINERACT-1806: Trigger event when charge-off happens
adamsaghy opened a new pull request, #2889:
URL: https://github.com/apache/fineract/pull/2889
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072099383
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanTransactionDataMapper.java:
##########
@@ -22,9 +22,11 @@
import org.apache.fineract.infrastructure.event.external.service.serialization.mapper.support.AvroMapperConfig;
import org.apache.fineract.portfolio.loanaccount.data.LoanTransactionData;
import org.mapstruct.Mapper;
+import org.mapstruct.Mapping;
@Mapper(config = AvroMapperConfig.class)
public interface LoanTransactionDataMapper {
+ @Mapping(target = "unpaidCharges", ignore = true)
Review Comment:
sure
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "chargeName",
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072063934
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
Review Comment:
This cannot be null, can it?
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "chargeName",
Review Comment:
Same here, name is mandatory for charges, isn't it?
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/UnpaidChargeData.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.loanaccount.data;
+
+import java.math.BigDecimal;
+import lombok.Getter;
+
+/**
+ * Immutable data object representing the total unpaid charge details
+ */
+@Getter
+public class UnpaidChargeData {
+
+ private final Long chargeId;
+ private final String chargeName;
+ private final BigDecimal outstandingAmount;
+
+ public UnpaidChargeData(Long chargeId, String chargeName, BigDecimal outstandingAmount) {
Review Comment:
Note if what I wrote in the Avro schema is true (i.e. not null values) then let's add null checks here to ensure we cannot create this object without having proper data in it.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanAccountDataMapper.java:
##########
@@ -36,5 +36,6 @@ public interface LoanAccountDataMapper {
@Mapping(source = "interestRecalculationEnabled", target = "isInterestRecalculationEnabled")
LoanAccountDataV1 map(LoanAccountData source);
+ @Mapping(target = "unpaidCharges", ignore = true)
Review Comment:
I don't think we even need this method here.
We could just modify the annotation on the class to this:
```
@Mapper(config = AvroMapperConfig.class, uses = { LoanTransactionDataMapper.class })
```
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanTransactionDataMapper.java:
##########
@@ -22,9 +22,11 @@
import org.apache.fineract.infrastructure.event.external.service.serialization.mapper.support.AvroMapperConfig;
import org.apache.fineract.portfolio.loanaccount.data.LoanTransactionData;
import org.mapstruct.Mapper;
+import org.mapstruct.Mapping;
@Mapper(config = AvroMapperConfig.class)
public interface LoanTransactionDataMapper {
+ @Mapping(target = "unpaidCharges", ignore = true)
Review Comment:
Can we put a comment here why this is ignored? Just for future reference.
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "chargeName",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "outstandingAmount",
Review Comment:
Can this be null or only zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2889:
URL: https://github.com/apache/fineract/pull/2889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072091551
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
Review Comment:
Fair point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072099130
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/UnpaidChargeData.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.loanaccount.data;
+
+import java.math.BigDecimal;
+import lombok.Getter;
+
+/**
+ * Immutable data object representing the total unpaid charge details
+ */
+@Getter
+public class UnpaidChargeData {
+
+ private final Long chargeId;
+ private final String chargeName;
+ private final BigDecimal outstandingAmount;
+
+ public UnpaidChargeData(Long chargeId, String chargeName, BigDecimal outstandingAmount) {
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072094462
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/mapper/loan/LoanAccountDataMapper.java:
##########
@@ -36,5 +36,6 @@ public interface LoanAccountDataMapper {
@Mapping(source = "interestRecalculationEnabled", target = "isInterestRecalculationEnabled")
LoanAccountDataV1 map(LoanAccountData source);
+ @Mapping(target = "unpaidCharges", ignore = true)
Review Comment:
I give a try :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2889: FINERACT-1806: Trigger event when charge-off happens
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2889:
URL: https://github.com/apache/fineract/pull/2889#discussion_r1072091915
##########
fineract-avro-schemas/src/main/avro/loan/v1/UnpaidChargeDataV1.avsc:
##########
@@ -0,0 +1,31 @@
+{
+ "name": "UnpaidChargeDataV1",
+ "namespace": "org.apache.fineract.avro.loan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "chargeId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "chargeName",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "outstandingAmount",
Review Comment:
Greater than 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org