You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/11 14:20:13 UTC

[GitHub] [incubator-yunikorn-core] manirajv06 commented on a change in pull request #229: YUNIKORN-466: Node capacity update does not update root queue or partition

manirajv06 commented on a change in pull request #229:
URL: https://github.com/apache/incubator-yunikorn-core/pull/229#discussion_r540979955



##########
File path: pkg/scheduler/partition.go
##########
@@ -586,6 +586,16 @@ func (pc *PartitionContext) removeNode(nodeID string) []*objects.Allocation {
 	return pc.removeNodeInternal(nodeID)
 }
 
+// Update a node

Review comment:
       > Can you also add unit test for the newly created method as part of the partition tests?
   
   Added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org