You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/15 19:59:47 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #10703: MINOR: Fix deprecation warnings in SlidingWindowedCogroupedKStreamImplTest
mjsax commented on a change in pull request #10703:
URL: https://github.com/apache/kafka/pull/10703#discussion_r632999895
##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java
##########
@@ -212,7 +212,7 @@ public void slidingWindowAggregateOverlappingWindowsTest() {
final TestInputTopic<String, String> testInputTopic = driver.createInputTopic(
TOPIC, new StringSerializer(), new StringSerializer());
final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic(
- OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer());
+ OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer());
Review comment:
as above
##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java
##########
@@ -156,7 +156,7 @@ public void slidingWindowAggregateStreamsTest() {
final TestInputTopic<String, String> testInputTopic = driver.createInputTopic(
TOPIC, new StringSerializer(), new StringSerializer());
final TestOutputTopic<Windowed<String>, String> testOutputTopic = driver.createOutputTopic(
- OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer()), new StringDeserializer());
+ OUTPUT, new TimeWindowedDeserializer<>(new StringDeserializer(), Long.MAX_VALUE), new StringDeserializer());
Review comment:
Seems we setup the window with `500ms`:
```
SlidingWindows.withTimeDifferenceAndGrace(ofMillis(500L),...)
```
Thus we should pass in the same value instead of `MAX_VAVLUE`.
We should also change `TestRecord<String,String>` below to `TestRecorded<Windowed<String>,String>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org