You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ilicmarkodb (via GitHub)" <gi...@apache.org> on 2026/03/03 23:16:16 UTC
[PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]
ilicmarkodb opened a new pull request, #54606:
URL: https://github.com/apache/spark/pull/54606
…_IF_NOT_EXISTS_AND_REPLACE
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Rename the legacy error class `_LEGACY_ERROR_TEMP_0052` to a proper descriptive name `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` and add SQL state 42601 (syntax error - conflicting SQL clauses).
This error is thrown when CREATE VIEW is used with both IF NOT EXISTS and REPLACE simultaneously.
### Why are the changes needed?
Proper error messaging.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
New unit test.
### Was this patch authored or co-authored using generative AI tooling?
Yes, co-authored with Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db closed pull request #54606: [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE`
URL: https://github.com/apache/spark/pull/54606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]
Posted by "ilicmarkodb (via GitHub)" <gi...@apache.org>.
ilicmarkodb commented on code in PR #54606:
URL: https://github.com/apache/spark/pull/54606#discussion_r2883070415
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -1049,6 +1049,12 @@
},
"sqlState" : "21S01"
},
+ "CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE" : {
+ "message" : [
+ "CREATE VIEW with both IF NOT EXISTS and REPLACE is not allowed."
Review Comment:
done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on code in PR #54606:
URL: https://github.com/apache/spark/pull/54606#discussion_r2882626976
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -1049,6 +1049,12 @@
},
"sqlState" : "21S01"
},
+ "CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE" : {
+ "message" : [
+ "CREATE VIEW with both IF NOT EXISTS and REPLACE is not allowed."
Review Comment:
Let's add the view name here to improve the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55822][SQL] Rename `_LEGACY_ERROR_TEMP_0052` to `CREATE_VIEW_WITH_IF_NOT_EXISTS_AND_REPLACE` [spark]
Posted by "ilicmarkodb (via GitHub)" <gi...@apache.org>.
ilicmarkodb commented on PR #54606:
URL: https://github.com/apache/spark/pull/54606#issuecomment-4003802559
@cloud-fan can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org