[jira] [Commented] (THRIFT-1866) java compiler generates non-compiling code with const's defined in a thrift file whose name includes non-identifier chars

["Bekir Oguz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633617#comment-14633617 ] 

Bekir Oguz commented on THRIFT-1866:
------------------------------------

I think this issue is already resolved with this commit for version 0.9.1:
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=commit;h=b3495ffd20cb4fa9b746eb7929c0b1a1b3c7615b

Thanks for the fix.

> java compiler generates non-compiling code with const's defined in a thrift file whose name includes non-identifier chars
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1866
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1866
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9
>         Environment: Mac OS X 10.7.5
>            Reporter: Bekir Oguz
>         Attachments: test-thrift.thrift
>
>
> Thrift-0.9 Java compiler generates non-compiling code when both the following conditions happen:
> * thrift file name includes a character which is not a valid java identifier (i.e. '-')
> * thrift file includes 'const' fields
> Thrift generates the Java file named <thriftFileName>Constants.java which is not compiling because of the non-identifier in the thriftFileName.
> Earlier thrift versions are fine because they generate only Constants.java file without prefixing thrift file name to it.
> Please find attached an example thrift file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)