Re: [PR] CAMEL-24063: Fix flaky DirectProducerBlockingTest.testProducerBlocksResumeTest [camel]

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on PR #24698:
URL: https://github.com/apache/camel/pull/24698#issuecomment-4993007096

   _Claude Code on behalf of gnodet_
   
   @apupier Thank you for the thorough review. After careful re-analysis of the Develocity data and stack traces, you were right on most points:
   
   - **DisruptorBlockWhenFullTest**: Dropped. The wrong method was being fixed — `testDisruptorBlockingWhenFull` has 0 flaky runs; the actually-flaky method is `testDisruptorExceptionWhenFull`.
   - **JmsAddAndRemoveRouteManagementIT**: Dropped. Already fixed by commit 148ac28d — 0 flaky runs since July 13.
   - **SchedulerNoPolledMessagesTest**: Dropped. The 4× widening from the prior commit didn't fix it, so further widening won't either. Needs proper root cause analysis.
   - **SedaBlockWhenFullTest**: Dropped. You correctly identified the failure mode as "too many messages received" — increasing timeouts makes it worse, not better.
   
   The PR now contains only **DirectProducerBlockingTest.testProducerBlocksResumeTest** fix, which I believe is correct: the `DirectConsumerNotAvailableException` IS what happens when the block timeout expires before the background thread resumes the route. Increasing both the Awaitility wait (2s→10s) and the sendBody timeout (2000→10000ms) gives the background thread enough headroom under CI load.
   
   The other 4 tests will be investigated separately with proper root cause analysis.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org