You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 12:08:07 UTC
[GitHub] [arrow] Dandandan opened a new pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArra::from_value to efficiently create an Array from a value
Dandandan opened a new pull request #9300:
URL: https://github.com/apache/arrow/pull/9300
In DataFusion (and probably this would pop up in more use cases) we want to efficiently create an array with `n` items with the same value (instead of creating it from a Vec of values or iterator).
As discussed in here:
https://github.com/apache/arrow/pull/9293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766324078
@jorgecarleitao I agree, it makes more sense to wait until this is faster and for now use the iterator for this case (even if it is slightl
I think at some point this version could be specialized to use (the soon stable) `slice.fill` though, which I expect would be faster than using an iterator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766321620
Do you see any difference between this one and using the iterator? I would expect them to perform equally well, since both are using `push`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766327769
Creating an null array with known size might be another that might come up in the future, but I am witholding that until it is supported by some use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan edited a comment on pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-766324078
@jorgecarleitao I agree, it makes more sense to wait until this is faster and for now use the iterator for this case (even if it is slightly more verbose).
I think at some point this version could be specialized to use (the soon stable) `slice.fill` though, which I expect would be faster than using an iterator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArra::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9300:
URL: https://github.com/apache/arrow/pull/9300#issuecomment-765925175
https://issues.apache.org/jira/browse/ARROW-11356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan closed pull request #9300: ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value
Posted by GitBox <gi...@apache.org>.
Dandandan closed pull request #9300:
URL: https://github.com/apache/arrow/pull/9300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org