You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Holger Hoffstätte (JIRA)" <ji...@apache.org> on 2009/12/29 18:44:29 UTC
[jira] Created: (DOSGI-54) RemoteServiceAdmin interfaces/classes
out of sync with official version
RemoteServiceAdmin interfaces/classes out of sync with official version
-----------------------------------------------------------------------
Key: DOSGI-54
URL: https://issues.apache.org/jira/browse/DOSGI-54
Project: CXF Distributed OSGi
Issue Type: Bug
Components: Discovery
Affects Versions: 1.1
Environment: tested with Java6 in eclipse
Reporter: Holger Hoffstätte
Priority: Critical
Fix For: 1.2
The interfaces/classes in the cxf-dosgi-remote-service-admin-interfaces module are out of sync with the official spec code from the OSGi alliance svn repo. With those classes on the classpath two tests fail (both for the same reason) in LocalDiscoveryUtilsTest.testAllEndpoints1/testAllEndpoints2:
--snip--
org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest
testAllEndpoints1(org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest)
java.lang.IllegalArgumentException: service.imported.configs property must be set and non-empty
at org.osgi.service.remoteserviceadmin.EndpointDescription.<init>(EndpointDescription.java:121)
at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getEndpointDescription(LocalDiscoveryUtils.java:160)
at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getAllEndpointDescriptions(LocalDiscoveryUtils.java:113)
at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest.testAllEndpoints1(LocalDiscoveryUtilsTest.java:184)
--snip--
This can be easily reproduced in eclipse by running LocalDiscoveryUtils with the current RSA classes in front of the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DOSGI-54) RemoteServiceAdmin interfaces/classes
out of sync with official version
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Holger Hoffstätte resolved DOSGI-54.
------------------------------------
Resolution: Duplicate
Apparently this is being fixed as part of DOSGI-13.
> RemoteServiceAdmin interfaces/classes out of sync with official version
> -----------------------------------------------------------------------
>
> Key: DOSGI-54
> URL: https://issues.apache.org/jira/browse/DOSGI-54
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Components: Discovery
> Affects Versions: 1.1
> Environment: tested with Java6 in eclipse
> Reporter: Holger Hoffstätte
> Priority: Critical
> Fix For: 1.2
>
> Attachments: EndpointDescriptions.patch
>
>
> The interfaces/classes in the cxf-dosgi-remote-service-admin-interfaces module are out of sync with the official spec code from the OSGi alliance svn repo. With those classes on the classpath two tests fail (both for the same reason) in LocalDiscoveryUtilsTest.testAllEndpoints1/testAllEndpoints2:
> --snip--
> org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest
> testAllEndpoints1(org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest)
> java.lang.IllegalArgumentException: service.imported.configs property must be set and non-empty
> at org.osgi.service.remoteserviceadmin.EndpointDescription.<init>(EndpointDescription.java:121)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getEndpointDescription(LocalDiscoveryUtils.java:160)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getAllEndpointDescriptions(LocalDiscoveryUtils.java:113)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest.testAllEndpoints1(LocalDiscoveryUtilsTest.java:184)
> --snip--
> This can be easily reproduced in eclipse by running LocalDiscoveryUtils with the current RSA classes in front of the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DOSGI-54) RemoteServiceAdmin interfaces/classes
out of sync with official version
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796791#action_12796791 ]
Holger Hoffstätte commented on DOSGI-54:
----------------------------------------
Same fix needs to be applied to the recently added ed3.xml and ed4.xml resources.
> RemoteServiceAdmin interfaces/classes out of sync with official version
> -----------------------------------------------------------------------
>
> Key: DOSGI-54
> URL: https://issues.apache.org/jira/browse/DOSGI-54
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Components: Discovery
> Affects Versions: 1.1
> Environment: tested with Java6 in eclipse
> Reporter: Holger Hoffstätte
> Priority: Critical
> Fix For: 1.2
>
> Attachments: EndpointDescriptions.patch
>
>
> The interfaces/classes in the cxf-dosgi-remote-service-admin-interfaces module are out of sync with the official spec code from the OSGi alliance svn repo. With those classes on the classpath two tests fail (both for the same reason) in LocalDiscoveryUtilsTest.testAllEndpoints1/testAllEndpoints2:
> --snip--
> org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest
> testAllEndpoints1(org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest)
> java.lang.IllegalArgumentException: service.imported.configs property must be set and non-empty
> at org.osgi.service.remoteserviceadmin.EndpointDescription.<init>(EndpointDescription.java:121)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getEndpointDescription(LocalDiscoveryUtils.java:160)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getAllEndpointDescriptions(LocalDiscoveryUtils.java:113)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest.testAllEndpoints1(LocalDiscoveryUtilsTest.java:184)
> --snip--
> This can be easily reproduced in eclipse by running LocalDiscoveryUtils with the current RSA classes in front of the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DOSGI-54) RemoteServiceAdmin interfaces/classes
out of sync with official version
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Holger Hoffstätte updated DOSGI-54:
-----------------------------------
Attachment: EndpointDescriptions.patch
The solution is to add the service.imported.configs property to all endpoint descriptions, since this property has been made mandatory (makes sense: otherwise an importer would have to "guess" the config type)
The attached patch simply adds the already-used cxf config type property to the EndpointDescriptions used by the failing tests. This lets the failing tests pass.
> RemoteServiceAdmin interfaces/classes out of sync with official version
> -----------------------------------------------------------------------
>
> Key: DOSGI-54
> URL: https://issues.apache.org/jira/browse/DOSGI-54
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Components: Discovery
> Affects Versions: 1.1
> Environment: tested with Java6 in eclipse
> Reporter: Holger Hoffstätte
> Priority: Critical
> Fix For: 1.2
>
> Attachments: EndpointDescriptions.patch
>
>
> The interfaces/classes in the cxf-dosgi-remote-service-admin-interfaces module are out of sync with the official spec code from the OSGi alliance svn repo. With those classes on the classpath two tests fail (both for the same reason) in LocalDiscoveryUtilsTest.testAllEndpoints1/testAllEndpoints2:
> --snip--
> org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest
> testAllEndpoints1(org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest)
> java.lang.IllegalArgumentException: service.imported.configs property must be set and non-empty
> at org.osgi.service.remoteserviceadmin.EndpointDescription.<init>(EndpointDescription.java:121)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getEndpointDescription(LocalDiscoveryUtils.java:160)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getAllEndpointDescriptions(LocalDiscoveryUtils.java:113)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest.testAllEndpoints1(LocalDiscoveryUtilsTest.java:184)
> --snip--
> This can be easily reproduced in eclipse by running LocalDiscoveryUtils with the current RSA classes in front of the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DOSGI-54) RemoteServiceAdmin interfaces/classes
out of sync with official version
Posted by "Holger Hoffstätte (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DOSGI-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795314#action_12795314 ]
Holger Hoffstätte commented on DOSGI-54:
----------------------------------------
It may also be useful to add an explicit assertion for the service.imported.config property into the unit test itself - not sure if that's worth the trouble though.
> RemoteServiceAdmin interfaces/classes out of sync with official version
> -----------------------------------------------------------------------
>
> Key: DOSGI-54
> URL: https://issues.apache.org/jira/browse/DOSGI-54
> Project: CXF Distributed OSGi
> Issue Type: Bug
> Components: Discovery
> Affects Versions: 1.1
> Environment: tested with Java6 in eclipse
> Reporter: Holger Hoffstätte
> Priority: Critical
> Fix For: 1.2
>
> Attachments: EndpointDescriptions.patch
>
>
> The interfaces/classes in the cxf-dosgi-remote-service-admin-interfaces module are out of sync with the official spec code from the OSGi alliance svn repo. With those classes on the classpath two tests fail (both for the same reason) in LocalDiscoveryUtilsTest.testAllEndpoints1/testAllEndpoints2:
> --snip--
> org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest
> testAllEndpoints1(org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest)
> java.lang.IllegalArgumentException: service.imported.configs property must be set and non-empty
> at org.osgi.service.remoteserviceadmin.EndpointDescription.<init>(EndpointDescription.java:121)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getEndpointDescription(LocalDiscoveryUtils.java:160)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtils.getAllEndpointDescriptions(LocalDiscoveryUtils.java:113)
> at org.apache.cxf.dosgi.discovery.local.LocalDiscoveryUtilsTest.testAllEndpoints1(LocalDiscoveryUtilsTest.java:184)
> --snip--
> This can be easily reproduced in eclipse by running LocalDiscoveryUtils with the current RSA classes in front of the classpath.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.