You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@apache.org> on 2019/08/28 16:40:34 UTC
Review Request 71394: Skipped GPG signing for snapshot builds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71394/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Bugs: MESOS-9955
https://issues.apache.org/jira/browse/MESOS-9955
Repository: mesos
Description
-------
Skipped GPG signing for snapshot builds.
Diffs
-----
support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3
Diff: https://reviews.apache.org/r/71394/diff/1/
Testing
-------
https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
Thanks,
Vinod Kone
Re: Review Request 71394: Skipped GPG signing for snapshot builds.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71394/#review217586
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Aug. 28, 2019, 4:40 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71394/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 4:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Skipped GPG signing for snapshot builds.
>
>
> Diffs
> -----
>
> support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3
>
>
> Diff: https://reviews.apache.org/r/71394/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 71394: Skipped GPG signing for snapshot builds.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71394/#review217533
-----------------------------------------------------------
Ship it!
LGTM, but I think a much preferable approach would have been to sign with a CI key. I'd be surprised if that wasn't already part of the ASF CI env (which includes lots of Java projects).
- Benjamin Bannier
On Aug. 28, 2019, 6:40 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71394/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2019, 6:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-9955
> https://issues.apache.org/jira/browse/MESOS-9955
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Skipped GPG signing for snapshot builds.
>
>
> Diffs
> -----
>
> support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3
>
>
> Diff: https://reviews.apache.org/r/71394/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
>
>
> Thanks,
>
> Vinod Kone
>
>