[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #758: new SeriesDataRandomReader

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #758: new SeriesDataRandomReader
URL: https://github.com/apache/incubator-iotdb/pull/758#discussion_r373402217
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/query/reader/seriesRelated/SeriesDataPointReader.java
 ##########
 @@ -18,37 +18,59 @@
  */
 package org.apache.iotdb.db.query.reader.seriesRelated;
 
+import java.io.IOException;
 import org.apache.iotdb.db.engine.querycontext.QueryDataSource;
 import org.apache.iotdb.db.query.context.QueryContext;
 import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
-import org.apache.iotdb.tsfile.file.metadata.statistics.Statistics;
+import org.apache.iotdb.tsfile.read.IPointReader;
 import org.apache.iotdb.tsfile.read.TimeValuePair;
 import org.apache.iotdb.tsfile.read.common.BatchData;
 import org.apache.iotdb.tsfile.read.common.Path;
 import org.apache.iotdb.tsfile.read.filter.basic.Filter;
 
-import java.io.IOException;
-
 
-public class SeriesReaderWithValueFilter extends SeriesReaderWithoutValueFilter {
+public class SeriesDataPointReader implements IPointReader {
 
-  private final Filter valueFilter;
+  private SeriesDataRandomReader randomReader;
   private boolean hasCachedTimeValuePair;
   private BatchData batchData;
   private TimeValuePair timeValuePair;
 
-  public SeriesReaderWithValueFilter(Path seriesPath, TSDataType dataType, Filter valueFilter,
-      QueryContext context, QueryDataSource dataSource) {
-    super(seriesPath, dataType, null, context, dataSource);
-    this.valueFilter = valueFilter;
+  public SeriesDataPointReader(Path seriesPath, TSDataType dataType, Filter timeFilter,
+      Filter valueFilter, QueryContext context, QueryDataSource dataSource) {
+    randomReader = new SeriesDataRandomReader(seriesPath, dataType, context,
+        dataSource.getSeqResources(), dataSource.getUnseqResources(), timeFilter, valueFilter);
 
 Review comment:
   ```suggestion
           dataSource.getSeqResources(), dataSource.getUnseqResources(), null, valueFilter);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services