[GitHub] [trafficcontrol] ocket8888 opened a new pull request #5972: Traffic Ops API Age Filtering

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #5972:
URL: https://github.com/apache/trafficcontrol/pull/5972


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   This PR adds support for the `newerThan` and `olderThan` query string parameters [as described in the documentation](https://traffic-control-cdn.readthedocs.io/en/latest/development/api_guidelines.html#age-filtering). It adds support in the internal query building helper function, `dbhelpers.BuildWhereAndOrderByAndPagination`, and implements it in the following API endpoints:
   
   - `/users`
   - `/topologies`
   - `/servers`
   - `/profiles`
   - `/parameters`
   - `/origins`
   - `/jobs`
   - `/federation_resolvers`
   - `/deliveryservices/{{ID}}/regexes`
   - `/servers/{{ID}}/deliveryservices`
   - `/deliveryservice_requests`
   - `/deliveryservices`
   - `/cdn_notifications`
   - `/cdn_locks`
   - `/capabilities`
   - `/cachegroups/{{ID}}/unassigned_parameters`
   - `/cachegroupparameters`
   - `/cachegroups`
   - `/api_capabilities`
   
   ## Which Traffic Control components are affected by this PR?
   - Documentation
   - Traffic Ops Client (Go) (tests only)
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Make sure the tests pass. This PR includes two unit tests for new functionality, and one integration test that checks the age filtering of Origins - other endpoints are possible to test (if harder, e.g. in the case of `/api_capabilities` where creating new objects through the API is not possible), they would end up testing the same functionality, so I didn't deem them valuable enough to write at this time.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes documentation
   - [x] This PR includes an update to CHANGELOG.md
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on pull request #5972: Traffic Ops API Age Filtering

[GitBox <gi...@apache.org>]

rawlinp commented on pull request #5972:
URL: https://github.com/apache/trafficcontrol/pull/5972#issuecomment-867838244


   What are the use cases behind this? Doesn't this duplicate IMS functionality in a way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org