You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/30 13:56:49 UTC
[GitHub] [spark] MaxGekk opened a new pull request #36014: [SPARK-38701][SQL] Inline `IllegalStateException` out from `QueryExecutionErrors`
MaxGekk opened a new pull request #36014:
URL: https://github.com/apache/spark/pull/36014
### What changes were proposed in this pull request?
In the PR, I propose to remove `IllegalStateException` from `QueryExecutionErrors`, and inline such exceptions in the places where they are used.
### Why are the changes needed?
To improve code maintenance. The exceptions of QueryExecutionErrors are supposed to migrate on error classes and be visible to users. `IllegalStateException` shouldn't be propagated to user space.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36014: [SPARK-38701][SQL] Inline `IllegalStateException` out from `QueryExecutionErrors`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #36014:
URL: https://github.com/apache/spark/pull/36014#issuecomment-1084092390
@cloud-fan @HyukjinKwon @gengliangwang Are you ok with the small changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36014: [SPARK-38701][SQL] Inline `IllegalStateException` out from `QueryExecutionErrors`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36014:
URL: https://github.com/apache/spark/pull/36014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36014: [SPARK-38701][SQL] Inline `IllegalStateException` out from `QueryExecutionErrors`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #36014:
URL: https://github.com/apache/spark/pull/36014#issuecomment-1084158725
Merging to master. Thank you, @HyukjinKwon and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org