[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3120: [Temp Partition] Support loading data into temp partitions

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #3120: [Temp Partition] Support loading data into temp partitions
URL: https://github.com/apache/incubator-doris/pull/3120#discussion_r393043523
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/AdminRepairTableStmt.java
 ##########
 @@ -62,8 +63,12 @@ public void analyze(Analyzer analyzer) throws UserException {
 
         tblRef.getName().setDb(dbName);
 
-        if (tblRef.getPartitions() != null && !tblRef.getPartitions().isEmpty()) {
-            partitions.addAll(tblRef.getPartitions());
+        PartitionNames partitionNames = tblRef.getPartitionNames();
 
 Review comment:
   Could we encapsulate the following logic?
   ```
    PartitionNames partitionNames = tblRef.getPartitionNames();
    if (partitionNames != null) {
               if (partitionNames.isTemp()) {
                   throw new AnalysisException("xxxx");
               }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org