You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/12 11:39:11 UTC

[GitHub] [dubbo-go] codecov-io commented on issue #316: add nacos configcenter

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=h1) Report
> Merging [#316](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/ab78c631e97aea00a3dd943b23e2974839651662?src=pr&el=desc) will **decrease** coverage by `1.64%`.
> The diff coverage is `41.24%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/316/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   66.59%   64.94%   -1.65%     
==========================================
  Files         112      117       +5     
  Lines        7175     7449     +274     
==========================================
+ Hits         4778     4838      +60     
- Misses       1932     2141     +209     
- Partials      465      470       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `12.5% <12.5%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `24.32% <24.32%> (ø)` | |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `35.61% <35.61%> (ø)` | |
| [config\_center/nacos/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9pbXBsLmdv) | `54.54% <54.54%> (ø)` | |
| [config\_center/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9saXN0ZW5lci5nbw==) | `88.23% <88.23%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `59.51% <0%> (-15.13%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/316/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=footer). Last update [ab78c63...d72c385](https://codecov.io/gh/apache/dubbo-go/pull/316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/316 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org