You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/12/07 12:54:43 UTC

[Impala-ASF-CR] IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

Tamas Mate has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19145 )

Change subject: IMPALA-11339: Add Iceberg LOAD DATA INPATH statement
......................................................................

IMPALA-11339: Add Iceberg LOAD DATA INPATH statement

Extend LOAD DATA INPATH statement to support Iceberg tables. Native
parquet tables need Iceberg field ids, therefore to add files this
change uses child queries to load and rewrite the data. The child
queries create > insert > drop the temporary table over the specified
directory.

The create part depends on LIKE PARQUET/ORC clauses to infer the file
format. This requires identifying a file in the directory and using that
to create the temporary table.

The target file or directory is moved to a staging directory before
ingestion similar to native file formats. In case of a query failure the
files are moved back to the original location. Child query executor will
return the error message of the failing query and the child query
profiles will be available through the WebUI.

At this point the PARTITION clause it not supported because it would
require analysis of the PartitionSpec (IMPALA-11750).

Testing:
 - Added e2e tests
 - Added fe unit tests

Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb
---
M be/src/service/client-request-state.cc
M common/thrift/Frontend.thrift
M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java
A fe/src/main/java/org/apache/impala/analysis/QueryStringBuilder.java
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test
M tests/query_test/test_iceberg.py
9 files changed, 578 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/19145/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19145
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8499945fa57ea0499f65b455976141dcd6d789eb
Gerrit-Change-Number: 19145
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>