You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sirona.apache.org by ol...@apache.org on 2014/02/06 04:43:27 UTC
svn commit: r1565066 -
/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Author: olamy
Date: Thu Feb 6 03:43:27 2014
New Revision: 1565066
URL: http://svn.apache.org/r1565066
Log:
avoid possible NPE
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Modified: incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1565066&r1=1565065&r2=1565066&view=diff
==============================================================================
--- incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java (original)
+++ incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java Thu Feb 6 03:43:27 2014
@@ -160,7 +160,8 @@ public class AgentContext {
public Class<?> keyAsClass() {
try {
- return keyAsMethod().getDeclaringClass();
+ Method method = keyAsMethod();
+ return method == null ? null : method.getDeclaringClass();
} catch (final Throwable th) {
return null;
}
Re: svn commit: r1565066 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Posted by Olivier Lamy <ol...@apache.org>.
arf need to sleep :-)
On 6 February 2014 17:07, Romain Manni-Bucau <rm...@gmail.com> wrote:
> So we remove Throwable catch? Normally NPE should have been correctly
> hidden ;)
> ---------- Message transféré ----------
> De : <ol...@apache.org>
> Date : 6 févr. 2014 04:43
> Objet : svn commit: r1565066 -
> /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> À : <co...@sirona.incubator.apache.org>
>
> Author: olamy
> Date: Thu Feb 6 03:43:27 2014
> New Revision: 1565066
>
> URL: http://svn.apache.org/r1565066
> Log:
> avoid possible NPE
>
> Modified:
>
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
>
> Modified:
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> URL:
> http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1565066&r1=1565065&r2=1565066&view=diff
> ==============================================================================
> ---
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> (original)
> +++
> incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
> Thu Feb 6 03:43:27 2014
> @@ -160,7 +160,8 @@ public class AgentContext {
>
> public Class<?> keyAsClass() {
> try {
> - return keyAsMethod().getDeclaringClass();
> + Method method = keyAsMethod();
> + return method == null ? null : method.getDeclaringClass();
> } catch (final Throwable th) {
> return null;
> }
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy
Fwd: svn commit: r1565066 - /incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Posted by Romain Manni-Bucau <rm...@gmail.com>.
So we remove Throwable catch? Normally NPE should have been correctly
hidden ;)
---------- Message transféré ----------
De : <ol...@apache.org>
Date : 6 févr. 2014 04:43
Objet : svn commit: r1565066 -
/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
À : <co...@sirona.incubator.apache.org>
Author: olamy
Date: Thu Feb 6 03:43:27 2014
New Revision: 1565066
URL: http://svn.apache.org/r1565066
Log:
avoid possible NPE
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Modified:
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
URL:
http://svn.apache.org/viewvc/incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java?rev=1565066&r1=1565065&r2=1565066&view=diff
==============================================================================
---
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
(original)
+++
incubator/sirona/trunk/agent/javaagent/src/main/java/org/apache/sirona/javaagent/AgentContext.java
Thu Feb 6 03:43:27 2014
@@ -160,7 +160,8 @@ public class AgentContext {
public Class<?> keyAsClass() {
try {
- return keyAsMethod().getDeclaringClass();
+ Method method = keyAsMethod();
+ return method == null ? null : method.getDeclaringClass();
} catch (final Throwable th) {
return null;
}