You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dark231321 (via GitHub)" <gi...@apache.org> on 2026/07/06 11:42:21 UTC
[PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
dark231321 opened a new pull request, #22763:
URL: https://github.com/apache/kafka/pull/22763
Fixes: https://issues.apache.org/jira/browse/KAFKA-20774
Defer removing an empty per-mechanism user map until all changes for that
mechanism have been applied in `ScramDelta.apply()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-5781958133
@dark231321 Thanks for the fix. It looks like the build failed. Can you trigger another run of the CI to confirm that the CI is green?
I am unable to rerun the tests. Maybe you can push a no-op commit to trigger a new CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-4924454469
> Can you please take a look?
I will take a look !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "dark231321 (via GitHub)" <gi...@apache.org>.
dark231321 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-4923873182
@chia7712 Can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "dark231321 (via GitHub)" <gi...@apache.org>.
dark231321 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-4894766396
@sjhajharia Could you please take a look when you have a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "dark231321 (via GitHub)" <gi...@apache.org>.
dark231321 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-5712627535
> Thanks for the PR @dark231321. LGTM
Thanks for the review and LGTM!
This is one of my first Kafka PRs, so I’m a bit unsure about the merge flow. GitHub still says it needs an approving review from someone with write access. Does that mean someone else still needs to take a look? And once that’s done, do committers usually merge it, or should I merge it myself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "dark231321 (via GitHub)" <gi...@apache.org>.
dark231321 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-4923869209
> @sjhajharia Could you please take a look when you have a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "dark231321 (via GitHub)" <gi...@apache.org>.
dark231321 closed pull request #22763: KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users
URL: https://github.com/apache/kafka/pull/22763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-5787810873
LGTM. I've rebased on the latest trunk to rerun CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-4965276311
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "kevin-wu24 (via GitHub)" <gi...@apache.org>.
kevin-wu24 commented on PR #22763:
URL: https://github.com/apache/kafka/pull/22763#issuecomment-5764224169
> Does that mean someone else still needs to take a look? And once that’s done, do committers usually merge it, or should I merge it myself?
Yes, you need a +1 from a committer. They will merge it if they approve.
cc @chia7712, would you be able to take a look when you have some time? The CI failures look unrelated to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20774: Fix ScramDelta.apply() dropping SCRAM users [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #22763:
URL: https://github.com/apache/kafka/pull/22763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org