You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/06 12:36:41 UTC
[GitHub] [airflow] potiuk opened a new pull request #18046: Fix building documentation broken by upgrade of dnspython
potiuk opened a new pull request #18046:
URL: https://github.com/apache/airflow/pull/18046
The automated upgrade of dependencies in main broken building of
Airflow documentation in main build.
After a lot of experimentation, It has been narrowed down
to upgrade of dnspython from 1.16.0 to 2.+ which was brought
by upgrading eventlet to 0.32.0.
This PR limits the dnspython library to < 2.0.0. An issue
has been opened:
https://github.com/rthalley/dnspython/issues/681
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913804574
All Green! We can have green `main` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913787414
Reopened to rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18046:
URL: https://github.com/apache/airflow/pull/18046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913787324
I think it is ready and it should fix failing main when merged - then we will be able to generate new constraints and refresh images and prepare 2.1.4 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #18046:
URL: https://github.com/apache/airflow/pull/18046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913806569
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913616409
It's DNS @ashb . It's always DNS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18046:
URL: https://github.com/apache/airflow/pull/18046#issuecomment-913804574
All Green! We can have green master too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org