You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 22:07:55 UTC

[GitHub] [incubator-superset] eschutho opened a new pull request #10923: upgrade cypress to use retries

eschutho opened a new pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923


   ### SUMMARY
   upgrades cypress to v 5.0 in order to use the new retries features. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   cypress tests pass, with potentially some retries. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-693716209


   retrigger FOSSA check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho edited a comment on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-693716209


   looks like we need https://github.com/apache/incubator-superset/pull/10925 to land in order for tests to pass. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai removed a comment on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
nytai removed a comment on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-693756748


   @eschutho I think you just need to rebase your branch to include in the latest fixes. I don't think CI is configured to run with a merge strategy. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-693756748


   @eschutho I think you just need to rebase your branch to include in the latest fixes. I don't think CI is configured to run with a merge strategy. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-694452321


   rerun for FOSSA


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho closed pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho edited a comment on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho edited a comment on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-694339401


   rerunning checks for fossa


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-693864565


   `explore/AdhocFilters.test.ts` failed too, but I disabled that one on `master`, rebasing should fix that issue.
   
   Personally I'd advise to also disable the whole `License` Github action as #10925 can re-enable it as it lands. 
   
   We've been suffering from flaky test/broken build for too long now. I vote for disabling all that fails and start clean.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho closed pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho closed pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho closed pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-694339401


   rerunning checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] eschutho commented on pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
eschutho commented on pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923#issuecomment-694475719


   @mistercrunch I'll continue to keep an eye on any tests that are failing after this and see which need to be fixed or disabled. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #10923: chore: upgrade cypress to use retries

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10923:
URL: https://github.com/apache/incubator-superset/pull/10923


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org