You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jesse Ciancetta (Created) (JIRA)" <ji...@apache.org> on 2012/01/27 21:08:10 UTC
[jira] [Created] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Cleanup NOTICE and LICENSE files
--------------------------------
Key: SHINDIG-1689
URL: https://issues.apache.org/jira/browse/SHINDIG-1689
Project: Shindig
Issue Type: Bug
Components: Build, Java
Reporter: Jesse Ciancetta
Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207374#comment-13207374 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
This addresses bug SHINDIG-1689.
https://issues.apache.org/jira/browse/SHINDIG-1689
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
Diff: https://reviews.apache.org/r/3887/diff
Testing
-------
Thanks,
Ate
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230075#comment-13230075 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-15 00:21:21, Ryan Baxter wrote:
bq. >
bq.
bq. Ryan Baxter wrote:
bq. Oops meant to add some context here before I published :)
bq.
bq. I am OK with these changes, Henry has asked the obvious changes. I am not really that familiar with some of the implications of these changes, so not sure how useful my review is. Just as a cleanup, I found some trailing whitespaces in the changes.
bq.
bq. Ate Douma wrote:
bq. Thanks Ryan.
bq. For removal of those whitespaces, would you prefer me to provide a new patch or is that something (automatically) can be taken care of by whom would commit the patch?
It's not to hard for committers to do it but if you have a sec to create a new patch it makes it a little easier on the committer.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "Ate Douma (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma updated SHINDIG-1689:
-------------------------------
Attachment: SHINDIG-1689.patch
Corresponding patch file for latest review at http://reviews.apache.org/r/3887/
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230146#comment-13230146 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/
-----------------------------------------------------------
(Updated 2012-03-15 13:10:51.557484)
Review request for shindig.
Changes
-------
Updated patch with only trailing whitespaces removed
Summary
-------
This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
This addresses bug SHINDIG-1689.
https://issues.apache.org/jira/browse/SHINDIG-1689
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
Diff: https://reviews.apache.org/r/3887/diff
Testing
-------
Thanks,
Ate
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235745#comment-13235745 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-21 22:09:24, Henry Saputra wrote:
bq. > Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
bq.
bq. Ate Douma wrote:
bq. The appended-resources directory is used by the maven-remote-resources-plugin in combination with the (default configured) apache-jar-resource-bundle.
bq. That resource bundle provides the standard ASL 2.0 LICENSE and basic NOTICE file (as velocity template).
bq. The plugin will look for matching resource *fragments* in the appended-resources folder and if found append them to the base template from the resource bundle.
bq. Effectively, this largely reduces the amount and size of to be provided LICENSE and NOTICE file per artifact/module, as only appendable fragments need to be provided, if needed at all.
bq.
bq. So the appended-resources directory is *not* automatically generated by my build but needed and used to generate final and complete LICENSE and NOTICE files.
Just committed the patch but looks like you just delete the content of features/NOTICE and other files instead of deleting the files themselves. Any reason why we need to have those empty files?
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229789#comment-13229789 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE
<https://reviews.apache.org/r/3887/#comment12961>
remove this whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE
<https://reviews.apache.org/r/3887/#comment12963>
whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE
<https://reviews.apache.org/r/3887/#comment12964>
whitespace
- Ryan
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "Henry Saputra (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra resolved SHINDIG-1689.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0
Assignee: Henry Saputra
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Assignee: Henry Saputra
> Fix For: 2.5.0
>
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235182#comment-13235182 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-21 22:09:24, Henry Saputra wrote:
bq. > Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
The appended-resources directory is used by the maven-remote-resources-plugin in combination with the (default configured) apache-jar-resource-bundle.
That resource bundle provides the standard ASL 2.0 LICENSE and basic NOTICE file (as velocity template).
The plugin will look for matching resource *fragments* in the appended-resources folder and if found append them to the base template from the resource bundle.
Effectively, this largely reduces the amount and size of to be provided LICENSE and NOTICE file per artifact/module, as only appendable fragments need to be provided, if needed at all.
So the appended-resources directory is *not* automatically generated by my build but needed and used to generate final and complete LICENSE and NOTICE files.
- Ate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235973#comment-13235973 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-21 22:09:24, Henry Saputra wrote:
bq. > Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
bq.
bq. Ate Douma wrote:
bq. The appended-resources directory is used by the maven-remote-resources-plugin in combination with the (default configured) apache-jar-resource-bundle.
bq. That resource bundle provides the standard ASL 2.0 LICENSE and basic NOTICE file (as velocity template).
bq. The plugin will look for matching resource *fragments* in the appended-resources folder and if found append them to the base template from the resource bundle.
bq. Effectively, this largely reduces the amount and size of to be provided LICENSE and NOTICE file per artifact/module, as only appendable fragments need to be provided, if needed at all.
bq.
bq. So the appended-resources directory is *not* automatically generated by my build but needed and used to generate final and complete LICENSE and NOTICE files.
bq.
bq. Henry Saputra wrote:
bq. Just committed the patch but looks like you just delete the content of features/NOTICE and other files instead of deleting the files themselves. Any reason why we need to have those empty files?
Weird. When I applied the patch myself using Eclipse to validate it, it actually did remove those empty files. Seems to depend on how you apply it or what tool you use.
It definitely is the intend to remove those empty files, so I suggest to now manually delete then.
Sorry for the inconvenience.
- Ate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229305#comment-13229305 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5944
-----------------------------------------------------------
Extra comments and will let some other people to chime in. ETA is end of week.
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12905>
http://www.apache.org/legal/src-headers.html#notice looks like its required
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12906>
As long as you have verified that no notice required for each of this 3rd party source code/ libraries than I am fine: http://apache.org/legal/resolved.html#required-third-party-notices
- Henry
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228901#comment-13228901 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5918
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12878>
The NOTICE file is only there and needed for legal purposes and should not be used for informational goals.
Question: what is a Shindig end user who would want to see what open source code is being used? Shindig being an OpenSocial container to be integrated, I'd say those users are developers and/or integrators. And those *should* go through both the LICENSE and NOTICE file.
And to provide more informational or 'friendly' attributions it is typically better to provide those through a README file instead which does not have any legal consequences. The NOTICE file has, as per ASL 2.0 section 4d).
So, it is strongly advised not to put anything in the NOTICE file which isn't legally required.
- Ate
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1689.
---------------------------------
part of 2.5.0-beta1 release.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Assignee: Henry Saputra
> Fix For: 2.5.0-beta1
>
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229334#comment-13229334 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5948
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12910>
It is required, but also already provided earlier in this NOTICE file. This removal is just a cleanup of redundant duplication of this required attribution.
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12911>
These 3rd party libraries do require a notice, but those are already and sufficiently provided within the LICENSE file and therefore not (also) required in the NOTICE file.
- Ate
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235981#comment-13235981 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-21 22:09:24, Henry Saputra wrote:
bq. > Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
bq.
bq. Ate Douma wrote:
bq. The appended-resources directory is used by the maven-remote-resources-plugin in combination with the (default configured) apache-jar-resource-bundle.
bq. That resource bundle provides the standard ASL 2.0 LICENSE and basic NOTICE file (as velocity template).
bq. The plugin will look for matching resource *fragments* in the appended-resources folder and if found append them to the base template from the resource bundle.
bq. Effectively, this largely reduces the amount and size of to be provided LICENSE and NOTICE file per artifact/module, as only appendable fragments need to be provided, if needed at all.
bq.
bq. So the appended-resources directory is *not* automatically generated by my build but needed and used to generate final and complete LICENSE and NOTICE files.
bq.
bq. Henry Saputra wrote:
bq. Just committed the patch but looks like you just delete the content of features/NOTICE and other files instead of deleting the files themselves. Any reason why we need to have those empty files?
bq.
bq. Ate Douma wrote:
bq. Weird. When I applied the patch myself using Eclipse to validate it, it actually did remove those empty files. Seems to depend on how you apply it or what tool you use.
bq. It definitely is the intend to remove those empty files, so I suggest to now manually delete then.
bq. Sorry for the inconvenience.
Will do thanks
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235092#comment-13235092 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
Actually I just noticed something when trying to commit. What is the appended-resources directory for? Is it automatically generated by your build? Seems like aggregation of the NOTICE and LICENSE files
- Henry
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229791#comment-13229791 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-15 00:21:21, Ryan Baxter wrote:
bq. >
Oops meant to add some context here before I published :)
I am OK with these changes, Henry has asked the obvious changes. I am not really that familiar with some of the implications of these changes, so not sure how useful my review is. Just as a cleanup, I found some trailing whitespaces in the changes.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228826#comment-13228826 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5912
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12872>
Any ASF legal issue about keeping the attributions?
Even though its not require but it helps end user to see what open source code is being used in Shindig without going through the LICENSE file.
- Henry
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228778#comment-13228778 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5904
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12865>
Because it is redundant. The exact same text is already provided just above this section.
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12867>
Because all these removed notices concern attributions already and sufficiently provided through their included license in the LICENSE file. And their license doesn't require additional attribution beyond that.
Note also the removed notice for OpenAjax. The OpenAjax implementation doesn't claim any copyright at all and is released under a verbatim copy of the ASL 2.0 license. So doesn't needs any specific or additional attribution beyond the ASL 2.0 license.
See for further background and argument: http://apache.org/legal/resolved.html#required-third-party-notices
Base principal is: the NOTICE file should only contain *required* attributions, and nothing beyond those, as our ASL 2.0 license section 4d) requires downstream users to redistribute everything which is provided in our NOTICE file (that is: when applicable)
http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE
<https://reviews.apache.org/r/3887/#comment12868>
Same answer as for the removed notices from the root NOTICE file:
Because all these removed notices concern attributions already and sufficiently provided through their included license in the LICENSE file. And these licenses (all BSD or MIT based) don't require additional attribution beyond that.
See for further background and argument: http://apache.org/legal/resolved.html#required-third-party-notices
Base principal is: the NOTICE file should only contain *required* attributions, and nothing beyond those, as our ASL 2.0 license section 4d) requires downstream users to redistribute everything which is provided in our NOTICE file (that is: when applicable)
- Ate
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230027#comment-13230027 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-15 00:21:21, Ryan Baxter wrote:
bq. >
bq.
bq. Ryan Baxter wrote:
bq. Oops meant to add some context here before I published :)
bq.
bq. I am OK with these changes, Henry has asked the obvious changes. I am not really that familiar with some of the implications of these changes, so not sure how useful my review is. Just as a cleanup, I found some trailing whitespaces in the changes.
Thanks Ryan.
For removal of those whitespaces, would you prefer me to provide a new patch or is that something (automatically) can be taken care of by whom would commit the patch?
- Ate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1689) Cleanup NOTICE and LICENSE files
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228561#comment-13228561 ]
jiraposter@reviews.apache.org commented on SHINDIG-1689:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5879
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12820>
Why is this removed?
http://svn.apache.org/repos/asf/shindig/trunk/NOTICE
<https://reviews.apache.org/r/3887/#comment12822>
Why are these removed?
http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE
<https://reviews.apache.org/r/3887/#comment12821>
Why are these removed?
- Henry
On 2012-02-14 00:03:44, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-14 00:03:44)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE requirements as reported here: http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated Copyright and license claim for OpenSocial 0.8 usages, see also: https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files reported by Ate Douma on the dev mailing list. Additional detail can be found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%3C4F20C2D2.9030000@douma.nu%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira