You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/07/09 18:08:33 UTC

[GitHub] [commons-lang] bjhargrave commented on pull request #578: Improve reproducibility of generated JARs

bjhargrave commented on pull request #578:
URL: https://github.com/apache/commons-lang/pull/578#issuecomment-656273624


   > finally, if the maven-bundle-plugin itself did:
   > `<_removeheaders.defaults>Include-Resource,Private-Package</_removeheaders.defaults>` these would also be added to anything the plugin consumer or parent pom sets.
   
   'maven-bundle-plugin` should not be using `Include-Resource` and `Private-Package` anyway. It should be using `-includeresource` and `-includepackage` (not `-privatepackage` so that `@Export` annotations are honored.).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org