[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8109: Add shmfs

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8109:
URL: https://github.com/apache/nuttx/pull/8109#discussion_r1070398118


##########
include/sys/syscall_lookup.h:
##########
@@ -333,6 +333,11 @@ SYSCALL_LOOKUP(munmap,                     2)
   SYSCALL_LOOKUP(mq_unlink,                1)
 #endif
 
+#ifdef CONFIG_FS_SHMFS

Review Comment:
   move before line 290



##########
sched/init/nx_start.c:
##########
@@ -588,6 +589,12 @@ void nx_start(void)
   nxmsg_initialize();
 #endif
 
+#ifdef CONFIG_FS_SHMFS
+  /* Initialize posix shm support */
+
+  shmfs_initialize();

Review Comment:
   move to fs_initialize



##########
fs/shm/Kconfig:
##########
@@ -3,16 +3,16 @@
 # see the file kconfig-language.txt in the NuttX tools repository.
 #
 
-config FS_SHM
+config FS_SHMFS
 	bool "Shared memory support"
 	default n
-	depends on MM_SHM
+	depends on ARCH_VMA_MAPPING || !BUILD_KERNEL

Review Comment:
   select ARCH_VMA_MAPPING like MM_SHM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org