You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/12/20 07:44:10 UTC
[GitHub] [ozone] jojochuang opened a new pull request #2934: HDDS-6125. Support Hugo 0.91.0.
jojochuang opened a new pull request #2934:
URL: https://github.com/apache/ozone/pull/2934
## What changes were proposed in this pull request?
Update config.yaml for Hugo to whitelist the environment variable OZONE_VERSION following the doc https://gohugo.io/about/security-model/
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6125
## How was this patch tested?
Built locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #2934: HDDS-6125. Support Hugo 0.91.0.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #2934:
URL: https://github.com/apache/ozone/pull/2934#issuecomment-997718068
Very nice. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #2934: HDDS-6125. Support Hugo 0.91.0.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #2934:
URL: https://github.com/apache/ozone/pull/2934#issuecomment-997673990
Create this PR to test against older version of Hugo. I was able to build the doc with Hugo 0.91.0 but not sure if the config file is backward compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2934: HDDS-6125. Support Hugo 0.91.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2934:
URL: https://github.com/apache/ozone/pull/2934#discussion_r772151824
##########
File path: hadoop-hdds/docs/config.yaml
##########
@@ -37,3 +37,21 @@ markup:
goldmark:
renderer:
unsafe: true
+security:
+ enableInlineShortcodes: false
+ exec:
+ allow:
+ - ^dart-sass-embedded$
+ - ^go$
+ - ^npx$
+ - ^postcss$
+ osEnv:
+ - (?i)^(PATH|PATHEXT|APPDATA|TMP|TEMP|TERM)$
Review comment:
We can omit these defaults.
```suggestion
```
(You can verify that they are still part of the config by making a typo in `OZONE_VERSION`, running `hugo` to reproduce the original issue, and checking the "current security configuration" included in the error message.)
##########
File path: hadoop-hdds/docs/config.yaml
##########
@@ -37,3 +37,21 @@ markup:
goldmark:
renderer:
unsafe: true
+security:
+ enableInlineShortcodes: false
+ exec:
+ allow:
+ - ^dart-sass-embedded$
+ - ^go$
+ - ^npx$
+ - ^postcss$
+ osEnv:
+ - (?i)^(PATH|PATHEXT|APPDATA|TMP|TEMP|TERM)$
+ funcs:
+ getenv:
+ - ^HUGO_|^OZONE_VERSION$
+ http:
+ methods:
+ - (?i)GET|POST
+ urls:
+ - .*
Review comment:
And these, too.
```suggestion
```
##########
File path: hadoop-hdds/docs/config.yaml
##########
@@ -37,3 +37,21 @@ markup:
goldmark:
renderer:
unsafe: true
+security:
+ enableInlineShortcodes: false
+ exec:
+ allow:
+ - ^dart-sass-embedded$
+ - ^go$
+ - ^npx$
+ - ^postcss$
+ osEnv:
+ - (?i)^(PATH|PATHEXT|APPDATA|TMP|TEMP|TERM)$
+ funcs:
+ getenv:
+ - ^HUGO_|^OZONE_VERSION$
Review comment:
I would replace regex "or" with yaml list:
```suggestion
funcs:
getenv:
- ^HUGO_
- ^OZONE_VERSION$
```
I think it will be friendlier for `git diff` in case changes are needed in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2934: HDDS-6125. Support Hugo 0.91.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2934:
URL: https://github.com/apache/ozone/pull/2934#issuecomment-998707638
Thanks @jojochuang for the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2934: HDDS-6125. Support Hugo 0.91.0.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2934:
URL: https://github.com/apache/ozone/pull/2934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org