You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:30:18 UTC
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #16: Fix do not have using absolute path of private key
wu-sheng commented on a change in pull request #16:
URL: https://github.com/apache/skywalking-java/pull/16#discussion_r699747063
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/TLSChannelBuilder.java
##########
@@ -58,7 +58,7 @@ public NettyChannelBuilder build(
if (certFile.isFile() && keyFile.isFile()) {
try (InputStream cert = new FileInputStream(certFile);
- InputStream key = PrivateKeyUtil.loadDecryptionKey(keyPath)) {
+ InputStream key = PrivateKeyUtil.loadDecryptionKey(keyFile.getAbsolutePath())) {
builder.keyManager(cert, key);
}
Review comment:
Is this a code format issue? The brace seems strange. Why there is `;` after try?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org