You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by oa...@apache.org on 2019/12/13 16:20:29 UTC
[camel-kafka-connector] branch fix-cs-code created (now f2efb39)
This is an automated email from the ASF dual-hosted git repository.
oalsafi pushed a change to branch fix-cs-code
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git.
at f2efb39 fix checkstyle violation
This branch includes the following new commits:
new f2efb39 fix checkstyle violation
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[camel-kafka-connector] 01/01: fix checkstyle violation
Posted by oa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
oalsafi pushed a commit to branch fix-cs-code
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git
commit f2efb39a52fb30781d4ff69b6717657fa216b3c7
Author: Omar Al-Safi <om...@gmail.com>
AuthorDate: Fri Dec 13 17:19:51 2019 +0100
fix checkstyle violation
---
.../camel/kafkaconnector/CamelSinkConnector.java | 1 +
.../kafkaconnector/CamelSinkConnectorConfig.java | 1 +
.../apache/camel/kafkaconnector/CamelSinkTask.java | 9 ++--
.../camel/kafkaconnector/CamelSourceConnector.java | 1 +
.../kafkaconnector/CamelSourceConnectorConfig.java | 5 ++-
.../camel/kafkaconnector/CamelSourceTask.java | 1 +
.../converters/S3ObjectConverter.java | 1 +
.../converters/S3ObjectSerializer.java | 1 +
.../converters/S3ObjectTransformer.java | 50 +++++++++++-----------
.../transforms/CamelTypeConverterTransform.java | 7 ++-
.../kafkaconnector/utils/CamelMainSupport.java | 2 +-
.../camel/kafkaconnector/utils/SchemaHelper.java | 3 ++
.../camel/kafkaconnector/CamelSinkTaskTest.java | 1 +
.../camel/kafkaconnector/DataFormatTest.java | 1 +
.../camel/kafkaconnector/PropertiesOrderTest.java | 1 +
.../test/TestBlockingQueueFactory.java | 1 +
.../kafkaconnector/utils/SchemaHelperTest.java | 2 +-
.../DefaultKafkaConnectPropertyFactory.java | 1 +
.../camel/kafkaconnector/KafkaConnectRunner.java | 4 +-
.../apache/camel/kafkaconnector/TestCommon.java | 4 +-
.../kafkaconnector/clients/jms/JMSClient.java | 1 +
.../kafka/DefaultConsumerPropertyFactory.java | 1 +
.../kafka/DefaultProducerPropertyFactory.java | 1 +
.../kafkaconnector/clients/kafka/KafkaClient.java | 3 +-
.../kafkaconnector/services/jms/JMSService.java | 2 +-
.../services/jms/JMSServiceFactory.java | 2 +-
.../sink/aws/sqs/CamelAWSSQSPropertyFactory.java | 1 +
.../sink/aws/sqs/CamelSinkAWSSQSITCase.java | 1 +
.../source/timer/CamelTimerPropertyFactory.java | 1 +
29 files changed, 64 insertions(+), 46 deletions(-)
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnector.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnector.java
index 39aef10..545a9ab 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnector.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnector.java
@@ -19,6 +19,7 @@ package org.apache.camel.kafkaconnector;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
+
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.connect.connector.Task;
import org.apache.kafka.connect.sink.SinkConnector;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnectorConfig.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnectorConfig.java
index bbfa11e..f75113b 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnectorConfig.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnectorConfig.java
@@ -17,6 +17,7 @@
package org.apache.camel.kafkaconnector;
import java.util.Map;
+
import org.apache.kafka.common.config.AbstractConfig;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.config.ConfigDef.Importance;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
index 02832ef..8e180d5 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkTask.java
@@ -21,6 +21,7 @@ import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+
import org.apache.camel.Exchange;
import org.apache.camel.ProducerTemplate;
import org.apache.camel.kafkaconnector.utils.CamelMainSupport;
@@ -125,9 +126,9 @@ public class CamelSinkTask extends SinkTask {
} else if (schema.type().getName().equalsIgnoreCase(Schema.INT8_SCHEMA.type().getName())) {
map.put(singleHeader.key(), (byte)singleHeader.value());
} else if (schema.type().getName().equalsIgnoreCase(SchemaBuilder.map(Schema.STRING_SCHEMA, Schema.STRING_SCHEMA).type().getName())) {
- map.put(singleHeader.key(), (Map)singleHeader.value());
+ map.put(singleHeader.key(), (Map)singleHeader.value());
} else if (schema.type().getName().equalsIgnoreCase(SchemaBuilder.array(Schema.STRING_SCHEMA).type().getName())) {
- map.put(singleHeader.key(), (List)singleHeader.value());
+ map.put(singleHeader.key(), (List)singleHeader.value());
}
}
@@ -152,9 +153,9 @@ public class CamelSinkTask extends SinkTask {
} else if (schema.type().getName().equalsIgnoreCase(Schema.INT8_SCHEMA.type().getName())) {
exchange.getProperties().put(singleHeader.key(), (byte)singleHeader.value());
} else if (schema.type().getName().equalsIgnoreCase(SchemaBuilder.map(Schema.STRING_SCHEMA, Schema.STRING_SCHEMA).type().getName())) {
- exchange.getProperties().put(singleHeader.key(), (Map)singleHeader.value());
+ exchange.getProperties().put(singleHeader.key(), (Map)singleHeader.value());
} else if (schema.type().getName().equalsIgnoreCase(SchemaBuilder.array(Schema.STRING_SCHEMA).type().getName())) {
- exchange.getProperties().put(singleHeader.key(), (List)singleHeader.value());
+ exchange.getProperties().put(singleHeader.key(), (List)singleHeader.value());
}
}
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnector.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnector.java
index 02a016d..1e0414f 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnector.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnector.java
@@ -19,6 +19,7 @@ package org.apache.camel.kafkaconnector;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
+
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.connect.connector.Task;
import org.apache.kafka.connect.source.SourceConnector;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnectorConfig.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnectorConfig.java
index 0d20d7b..70ce529 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnectorConfig.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceConnectorConfig.java
@@ -17,6 +17,7 @@
package org.apache.camel.kafkaconnector;
import java.util.Map;
+
import org.apache.kafka.common.config.AbstractConfig;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.config.ConfigDef.Importance;
@@ -49,8 +50,8 @@ public class CamelSourceConnectorConfig extends AbstractConfig {
public static final String CAMEL_SOURCE_MESSAGE_HEADER_KEY_DEFAULT = null;
public static final String CAMEL_SOURCE_MESSAGE_HEADER_KEY_CONF = "camel.source.camelMessageHeaderKey";
- public static final String CAMEL_SOURCE_MESSAGE_HEADER_KEY_DOC = "The camel message header key that contain an unique key for the message which can be used a Kafka message key. If this is not specified, then the Kafka message will not have a key";
-
+ public static final String CAMEL_SOURCE_MESSAGE_HEADER_KEY_DOC = "The camel message header key that contain an unique key for the message which can be used a Kafka message key."
+ + " If this is not specified, then the Kafka message will not have a key";
private static final String CAMEL_SOURCE_URL_DOC = "The camel url to configure the source";
private static final String CAMEL_SOURCE_UNMARSHAL_DOC = "The camel dataformat name to use to unmarshal data from the source";
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java
index 1011910..2c39f1e 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/CamelSourceTask.java
@@ -26,6 +26,7 @@ import java.util.Collections;
import java.util.Date;
import java.util.List;
import java.util.Map;
+
import org.apache.camel.Endpoint;
import org.apache.camel.Exchange;
import org.apache.camel.PollingConsumer;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
index 59678d6..a74eb5d 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
@@ -17,6 +17,7 @@
package org.apache.camel.kafkaconnector.converters;
import java.util.Map;
+
import com.amazonaws.services.s3.model.S3ObjectInputStream;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.data.SchemaAndValue;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
index fbfac33..b55579e 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
@@ -20,6 +20,7 @@ import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.util.Map;
+
import com.amazonaws.services.s3.model.S3ObjectInputStream;
import org.apache.kafka.common.serialization.Serializer;
import org.slf4j.Logger;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectTransformer.java b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectTransformer.java
index 1692e51..dc9e427 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectTransformer.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectTransformer.java
@@ -18,39 +18,37 @@ package org.apache.camel.kafkaconnector.converters;
import java.util.Map;
+import com.amazonaws.services.s3.model.S3ObjectInputStream;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.connect.connector.ConnectRecord;
import org.apache.kafka.connect.data.Schema;
import org.apache.kafka.connect.transforms.Transformation;
-import com.amazonaws.services.s3.model.S3ObjectInputStream;
-
public class S3ObjectTransformer<R extends ConnectRecord<R>> implements Transformation<R> {
- private final S3ObjectSerializer serializer = new S3ObjectSerializer();
-
public static final ConfigDef CONFIG_DEF = new ConfigDef()
- .define("test", ConfigDef.Type.STRING, "test", ConfigDef.Importance.MEDIUM,
- "Transform the content of a bucket into a string ");
-
- @Override
- public void configure(Map<String, ?> configs) {
- }
-
- @Override
- public R apply(R record) {
- byte[] v = serializer.serialize(record.topic(), (S3ObjectInputStream) record.value());
- String finalValue = new String(v);
- return record.newRecord(record.topic(), record.kafkaPartition(), null, record.key(), Schema.STRING_SCHEMA, finalValue, record.timestamp());
- }
-
- @Override
- public void close() {
- }
-
- @Override
- public ConfigDef config() {
- return CONFIG_DEF;
- }
+ .define("test", ConfigDef.Type.STRING, "test", ConfigDef.Importance.MEDIUM, "Transform the content of a bucket into a string ");
+
+ private final S3ObjectSerializer serializer = new S3ObjectSerializer();
+
+ @Override
+ public void configure(Map<String, ?> configs) {
+ }
+
+ @Override
+ public R apply(R record) {
+ byte[] v = serializer.serialize(record.topic(), (S3ObjectInputStream) record.value());
+ String finalValue = new String(v);
+ return record.newRecord(record.topic(), record.kafkaPartition(), null, record.key(), Schema.STRING_SCHEMA, finalValue, record.timestamp());
+ }
+
+ @Override
+ public void close() {
+ }
+
+ @Override
+ public ConfigDef config() {
+ return CONFIG_DEF;
+ }
}
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/transforms/CamelTypeConverterTransform.java b/core/src/main/java/org/apache/camel/kafkaconnector/transforms/CamelTypeConverterTransform.java
index 2727d61..0a88859 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/transforms/CamelTypeConverterTransform.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/transforms/CamelTypeConverterTransform.java
@@ -32,14 +32,13 @@ import org.apache.kafka.connect.transforms.util.SimpleConfig;
public abstract class CamelTypeConverterTransform<R extends ConnectRecord<R>> extends CamelTransformSupport<R> {
public static final String FIELD_TARGET_TYPE_CONFIG = "target.type";
-
- private static TypeConverter typeConverter;
- private Class<?> fieldTargetType;
-
public static final ConfigDef CONFIG_DEF = new ConfigDef()
.define(FIELD_TARGET_TYPE_CONFIG, ConfigDef.Type.CLASS, null, ConfigDef.Importance.HIGH,
"The target field type to convert the value from, this is full qualified Java class, e.g: java.util.Map");
+ private static TypeConverter typeConverter;
+ private Class<?> fieldTargetType;
+
@Override
public R apply(R record) {
final Schema schema = operatingSchema(record);
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/utils/CamelMainSupport.java b/core/src/main/java/org/apache/camel/kafkaconnector/utils/CamelMainSupport.java
index 1fc2574..df0ed20 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/utils/CamelMainSupport.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/utils/CamelMainSupport.java
@@ -23,6 +23,7 @@ import java.util.Properties;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
+
import org.apache.camel.CamelContext;
import org.apache.camel.CamelContextAware;
import org.apache.camel.ConsumerTemplate;
@@ -33,7 +34,6 @@ import org.apache.camel.impl.DefaultCamelContext;
import org.apache.camel.main.BaseMainSupport;
import org.apache.camel.main.Main;
import org.apache.camel.main.MainListener;
-import org.apache.camel.main.MainSupport;
import org.apache.camel.model.RouteDefinition;
import org.apache.camel.spi.DataFormat;
import org.apache.camel.support.PropertyBindingSupport;
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/utils/SchemaHelper.java b/core/src/main/java/org/apache/camel/kafkaconnector/utils/SchemaHelper.java
index b0e08a4..4caef83 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/utils/SchemaHelper.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/utils/SchemaHelper.java
@@ -30,6 +30,9 @@ import org.apache.kafka.connect.transforms.util.SchemaUtil;
public final class SchemaHelper {
+ private SchemaHelper() {
+ }
+
/**
* Try to build a {@link SchemaBuilder} for a value of type {@link Object}
* However, this will only build the schema only for known types, in case it can not return the precise SchemaBuilder type
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/CamelSinkTaskTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/CamelSinkTaskTest.java
index 4c529e3..cecf5f7 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/CamelSinkTaskTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/CamelSinkTaskTest.java
@@ -21,6 +21,7 @@ import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+
import com.fasterxml.jackson.core.JsonProcessingException;
import org.apache.camel.ConsumerTemplate;
import org.apache.camel.Exchange;
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
index 0aafa5d..2830b47 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
@@ -18,6 +18,7 @@ package org.apache.camel.kafkaconnector;
import java.util.HashMap;
import java.util.Map;
+
import com.fasterxml.jackson.core.JsonProcessingException;
import org.apache.camel.component.hl7.HL7DataFormat;
import org.apache.camel.impl.DefaultCamelContext;
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/PropertiesOrderTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/PropertiesOrderTest.java
index 1229c03..d2995a3 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/PropertiesOrderTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/PropertiesOrderTest.java
@@ -18,6 +18,7 @@ package org.apache.camel.kafkaconnector;
import java.util.HashMap;
import java.util.Map;
+
import com.fasterxml.jackson.core.JsonProcessingException;
import org.junit.Test;
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/test/TestBlockingQueueFactory.java b/core/src/test/java/org/apache/camel/kafkaconnector/test/TestBlockingQueueFactory.java
index df79be0..b273ac7 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/test/TestBlockingQueueFactory.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/test/TestBlockingQueueFactory.java
@@ -17,6 +17,7 @@
package org.apache.camel.kafkaconnector.test;
import java.util.concurrent.BlockingQueue;
+
import org.apache.camel.component.seda.ArrayBlockingQueueFactory;
import org.apache.camel.component.seda.BlockingQueueFactory;
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/utils/SchemaHelperTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/utils/SchemaHelperTest.java
index b1b881b..9dc9b1c 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/utils/SchemaHelperTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/utils/SchemaHelperTest.java
@@ -79,5 +79,5 @@ public class SchemaHelperTest {
// finally how to handle if we have no idea about the value
final S3ObjectInputStream s3ObjectInputStream = new S3ObjectInputStream(System.in, new HttpDelete());
assertEquals(Schema.Type.BYTES, SchemaHelper.buildSchemaBuilderForType(s3ObjectInputStream).type());
- }
+ }
}
\ No newline at end of file
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/DefaultKafkaConnectPropertyFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/DefaultKafkaConnectPropertyFactory.java
index bd55b3d..9425a4a 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/DefaultKafkaConnectPropertyFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/DefaultKafkaConnectPropertyFactory.java
@@ -18,6 +18,7 @@
package org.apache.camel.kafkaconnector;
import java.util.Properties;
+
import org.apache.kafka.connect.runtime.standalone.StandaloneConfig;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/KafkaConnectRunner.java b/tests/src/test/java/org/apache/camel/kafkaconnector/KafkaConnectRunner.java
index 7292c6f..5118853 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/KafkaConnectRunner.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/KafkaConnectRunner.java
@@ -24,8 +24,6 @@ import java.util.Properties;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutionException;
-import static junit.framework.TestCase.fail;
-
import org.apache.kafka.common.utils.Time;
import org.apache.kafka.common.utils.Utils;
import org.apache.kafka.connect.runtime.Connect;
@@ -44,6 +42,8 @@ import org.apache.kafka.connect.util.FutureCallback;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static junit.framework.TestCase.fail;
+
/**
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/TestCommon.java b/tests/src/test/java/org/apache/camel/kafkaconnector/TestCommon.java
index 05719e6..edf83fd 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/TestCommon.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/TestCommon.java
@@ -18,11 +18,11 @@ package org.apache.camel.kafkaconnector;
import java.util.Properties;
-import static junit.framework.TestCase.fail;
-
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static junit.framework.TestCase.fail;
+
/**
* Common test constants and utilities
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/jms/JMSClient.java b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/jms/JMSClient.java
index cf4970b..0ff99ad 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/jms/JMSClient.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/jms/JMSClient.java
@@ -20,6 +20,7 @@ package org.apache.camel.kafkaconnector.clients.jms;
import java.util.Properties;
import java.util.function.Function;
import java.util.function.Predicate;
+
import javax.jms.Connection;
import javax.jms.ConnectionFactory;
import javax.jms.DeliveryMode;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultConsumerPropertyFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultConsumerPropertyFactory.java
index 217adbb..ae51354 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultConsumerPropertyFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultConsumerPropertyFactory.java
@@ -19,6 +19,7 @@ package org.apache.camel.kafkaconnector.clients.kafka;
import java.util.Properties;
import java.util.UUID;
+
import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.common.serialization.StringDeserializer;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultProducerPropertyFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultProducerPropertyFactory.java
index c6d72d2..94b3578 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultProducerPropertyFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/DefaultProducerPropertyFactory.java
@@ -19,6 +19,7 @@ package org.apache.camel.kafkaconnector.clients.kafka;
import java.util.Properties;
import java.util.UUID;
+
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.serialization.StringSerializer;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/KafkaClient.java b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/KafkaClient.java
index 0cc402c..083abd4 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/KafkaClient.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/kafka/KafkaClient.java
@@ -23,14 +23,13 @@ import java.util.Properties;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.function.Predicate;
+
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.consumer.ConsumerRecords;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.producer.KafkaProducer;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.clients.producer.RecordMetadata;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* A very simple test message consumer that can consume messages of different types
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSService.java b/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSService.java
index 963a4ae..7480d28 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSService.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSService.java
@@ -31,5 +31,5 @@ public abstract class JMSService extends GenericContainer {
* Gets the default endpoint for the JMS service (ie.: amqp://host:port, or tcp://host:port, etc)
* @return the endpoint URL as a string in the specific format used by the service
*/
- abstract public String getDefaultEndpoint();
+ public abstract String getDefaultEndpoint();
}
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSServiceFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSServiceFactory.java
index 75853e4..aa18498 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSServiceFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/services/jms/JMSServiceFactory.java
@@ -20,7 +20,7 @@ package org.apache.camel.kafkaconnector.services.jms;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class JMSServiceFactory {
+public final class JMSServiceFactory {
private static final Logger LOG = LoggerFactory.getLogger(JMSServiceFactory.class);
private JMSServiceFactory() {
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelAWSSQSPropertyFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelAWSSQSPropertyFactory.java
index 68d84fd..27a7f2b 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelAWSSQSPropertyFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelAWSSQSPropertyFactory.java
@@ -18,6 +18,7 @@
package org.apache.camel.kafkaconnector.sink.aws.sqs;
import java.util.Properties;
+
import org.apache.camel.kafkaconnector.AWSConfigs;
import org.apache.camel.kafkaconnector.ConnectorPropertyFactory;
import org.apache.kafka.connect.runtime.ConnectorConfig;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelSinkAWSSQSITCase.java b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelSinkAWSSQSITCase.java
index 04af35e..ae59168 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelSinkAWSSQSITCase.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/aws/sqs/CamelSinkAWSSQSITCase.java
@@ -23,6 +23,7 @@ import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
+
import com.amazonaws.services.sqs.model.Message;
import org.apache.camel.kafkaconnector.AbstractKafkaTest;
import org.apache.camel.kafkaconnector.ConnectorPropertyFactory;
diff --git a/tests/src/test/java/org/apache/camel/kafkaconnector/source/timer/CamelTimerPropertyFactory.java b/tests/src/test/java/org/apache/camel/kafkaconnector/source/timer/CamelTimerPropertyFactory.java
index 399c1b0..1d459c4 100644
--- a/tests/src/test/java/org/apache/camel/kafkaconnector/source/timer/CamelTimerPropertyFactory.java
+++ b/tests/src/test/java/org/apache/camel/kafkaconnector/source/timer/CamelTimerPropertyFactory.java
@@ -18,6 +18,7 @@
package org.apache.camel.kafkaconnector.source.timer;
import java.util.Properties;
+
import org.apache.camel.kafkaconnector.ConnectorPropertyFactory;
import org.apache.kafka.connect.runtime.ConnectorConfig;