You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/10/31 17:52:52 UTC
Review Request 27430: Fix KAFKA-1720
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1720
https://issues.apache.org/jira/browse/KAFKA-1720
Repository: kafka
Description
-------
Rename delayed requests to delayed operations, change some class names
Diffs
-----
core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92
core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439
core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8
core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d
core/src/main/scala/kafka/server/ReplicaManager.scala 02fa3821271e97b24fd2ae25163933222797585d
core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
Diff: https://reviews.apache.org/r/27430/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 27430: Fix KAFKA-1720
Posted by Guozhang Wang <wa...@gmail.com>.
> On Nov. 25, 2014, 5:50 p.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/server/ReplicaManager.scala, line 87
> > <https://reviews.apache.org/r/27430/diff/2/?file=746549#file746549line87>
> >
> > In Kafka-1583 we had discussed renaming ReplicaManager to ReplicatedLogManager or something like that.
I think as discussed this change will not be done until after the coordinator and the controller refactoring work.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/#review63003
-----------------------------------------------------------
On Nov. 1, 2014, 12:21 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27430/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 12:21 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1720
> https://issues.apache.org/jira/browse/KAFKA-1720
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rename delayed requests to delayed operations, change some class names
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92
> core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439
> core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8
> core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d
> core/src/main/scala/kafka/server/ReplicaManager.scala 3007a6d89b637b93f71fdb7adab561a93d9c4c62
> core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
> core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
> system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
>
> Diff: https://reviews.apache.org/r/27430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 27430: Fix KAFKA-1720
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/#review63003
-----------------------------------------------------------
core/src/main/scala/kafka/server/ReplicaManager.scala
<https://reviews.apache.org/r/27430/#comment105181>
In Kafka-1583 we had discussed renaming ReplicaManager to ReplicatedLogManager or something like that.
- Joel Koshy
On Nov. 1, 2014, 12:21 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27430/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 12:21 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1720
> https://issues.apache.org/jira/browse/KAFKA-1720
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rename delayed requests to delayed operations, change some class names
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92
> core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439
> core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8
> core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d
> core/src/main/scala/kafka/server/ReplicaManager.scala 3007a6d89b637b93f71fdb7adab561a93d9c4c62
> core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
> core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
> system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
>
> Diff: https://reviews.apache.org/r/27430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 27430: Fix KAFKA-1720
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/#review63803
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On Dec. 3, 2014, 9:34 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27430/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 9:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1720
> https://issues.apache.org/jira/browse/KAFKA-1720
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rebased
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala b9fde2aacbb1fae9e18942dc81fa63c53b9fdb5f
> core/src/main/scala/kafka/server/DelayedFetch.scala 1e2e56f87a3c2e8079e4ad7241a1ab945eeb638c
> core/src/main/scala/kafka/server/DelayedOperationKey.scala PRE-CREATION
> core/src/main/scala/kafka/server/DelayedProduce.scala 1603066d33f82290f3e9b8c5f1a9092d26cf86b8
> core/src/main/scala/kafka/server/ReplicaManager.scala b3566b0bc33fe335bd1009deee1e011ff245e01a
> core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
> core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
> system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
>
> Diff: https://reviews.apache.org/r/27430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 27430: Fix KAFKA-1720
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 9:34 p.m.)
Review request for kafka.
Bugs: KAFKA-1720
https://issues.apache.org/jira/browse/KAFKA-1720
Repository: kafka
Description (updated)
-------
Rebased
Diffs (updated)
-----
core/src/main/scala/kafka/cluster/Partition.scala b9fde2aacbb1fae9e18942dc81fa63c53b9fdb5f
core/src/main/scala/kafka/server/DelayedFetch.scala 1e2e56f87a3c2e8079e4ad7241a1ab945eeb638c
core/src/main/scala/kafka/server/DelayedOperationKey.scala PRE-CREATION
core/src/main/scala/kafka/server/DelayedProduce.scala 1603066d33f82290f3e9b8c5f1a9092d26cf86b8
core/src/main/scala/kafka/server/ReplicaManager.scala b3566b0bc33fe335bd1009deee1e011ff245e01a
core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
Diff: https://reviews.apache.org/r/27430/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 27430: Fix KAFKA-1720
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/#review59453
-----------------------------------------------------------
Ship it!
LGTM :)
- Gwen Shapira
On Nov. 1, 2014, 12:21 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27430/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2014, 12:21 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1720
> https://issues.apache.org/jira/browse/KAFKA-1720
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Rename delayed requests to delayed operations, change some class names
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92
> core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439
> core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8
> core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d
> core/src/main/scala/kafka/server/ReplicaManager.scala 3007a6d89b637b93f71fdb7adab561a93d9c4c62
> core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
> core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
> system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
>
> Diff: https://reviews.apache.org/r/27430/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 27430: Fix KAFKA-1720
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27430/
-----------------------------------------------------------
(Updated Nov. 1, 2014, 12:21 a.m.)
Review request for kafka.
Bugs: KAFKA-1720
https://issues.apache.org/jira/browse/KAFKA-1720
Repository: kafka
Description
-------
Rename delayed requests to delayed operations, change some class names
Diffs (updated)
-----
core/src/main/scala/kafka/cluster/Partition.scala 1be57008e983fc3a831626ecf9a861f164fcca92
core/src/main/scala/kafka/server/DelayedFetch.scala 1ccbb4b6fdbbd4412ba77ffe7d4cf5adf939e439
core/src/main/scala/kafka/server/DelayedProduce.scala 8049e07e5d6d65913ec2492f1e22e5ed3ecbbea8
core/src/main/scala/kafka/server/DelayedRequestKey.scala 628ef59564b9b9238d7b05d26aef79d3cfec174d
core/src/main/scala/kafka/server/ReplicaManager.scala 3007a6d89b637b93f71fdb7adab561a93d9c4c62
core/src/main/scala/kafka/server/RequestPurgatory.scala 323b12e765f981e9bba736a204e4a8159e5c5ada
core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala a7720d579ea15b71511c9da0e241bd087de3674e
system_test/metrics.json cd3fc142176b8a3638db5230fb74f055c04c59d4
Diff: https://reviews.apache.org/r/27430/diff/
Testing
-------
Thanks,
Guozhang Wang