You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/26 18:32:05 UTC
[GitHub] [calcite] laurentgo commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…
laurentgo commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307862392
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -2656,10 +2718,10 @@ public int compareTo(@Nonnull CorDef o) {
* updated.
*
* </ol> */
- private static class CorelMap {
- private final Multimap<RelNode, CorRef> mapRefRelToCorRef;
- private final SortedMap<CorrelationId, RelNode> mapCorToCorRel;
- private final Map<RexFieldAccess, CorRef> mapFieldAccessToCorRef;
+ protected static class CorelMap {
+ protected final Multimap<RelNode, CorRef> mapRefRelToCorRef;
+ public final SortedMap<CorrelationId, RelNode> mapCorToCorRel;
Review comment:
this seems "dangerous" to make the set public
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services