[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #5470: [fix-5453](pydevlake): Make ScopeConfig optional

["CamilleTeruel (via GitHub)" <gi...@apache.org>]

CamilleTeruel commented on code in PR #5470:
URL: https://github.com/apache/incubator-devlake/pull/5470#discussion_r1230646088


##########
backend/server/services/remote/plugin/plugin_impl.go:
##########
@@ -176,8 +177,10 @@ func (p *remotePluginImpl) getScopeAndConfig(db dal.Dal, connectionId uint64, sc
 		if err != nil {
 			return nil, nil, err
 		}
+		return wrappedScope.Unwrap(), wrappedScopeConfig.Unwrap(), nil
+	} else {
+		return wrappedScope.Unwrap(), nil, nil

Review Comment:
   > Was `wrappedScopeConfig.Unwrap()` not just resolving to nil here?
   
   No this resolves to a zeroed scope config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org