You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "simbit18 (via GitHub)" <gi...@apache.org> on 2024/09/25 10:55:07 UTC

[PR] ci/platforms/msys2.sh: update esptool version and switch Wget to cURL tool [nuttx]

simbit18 opened a new pull request, #13608:
URL: https://github.com/apache/nuttx/pull/13608

   ## Summary
   
   Bumps esptool from 4.7.0 to 4.8.0.
   
   Switch wget to cURL tool for:
   arm_gcc_toolchain()
   arm64_gcc_toolchain()
   riscv_gcc_toolchain()
   sparc_gcc_toolchain()
   xtensa_esp32_gcc_toolchain()
   xtensa_esp32s2_gcc_toolchain()
   xtensa_esp32s3_gcc_toolchain()
   
   Used git clone --depth 1 a shallow clone with a history truncated for:
   gen_romfs()
   kconfig_frontends()
   
   ## Impact
   There should be no impact.
   
   ## Testing
   CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci/platforms/msys2.sh: update esptool version and switch Wget to cURL tool [nuttx]

Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #13608:
URL: https://github.com/apache/nuttx/pull/13608#issuecomment-2374493309

   @xiaoxiang781216 Sure I will update in 2 new PR one for macOS platform and other for Linux Ubuntu platforms.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci/platforms/msys2.sh: update esptool version and switch Wget to cURL tool [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #13608:
URL: https://github.com/apache/nuttx/pull/13608#issuecomment-2374478367

   @simbit18 should we switch all download from wget to curl?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci/platforms/msys2.sh: update esptool version and switch Wget to cURL tool [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13608:
URL: https://github.com/apache/nuttx/pull/13608#issuecomment-2373752753

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This PR appears to meet the NuttX requirements, but there are some minor omissions:
   
   **Summary:**
   
   * **Why is this change necessary?**  The summary should briefly state the reason for bumping esptool and switching to cURL. Is it for bug fixes, performance improvements, new features in the newer versions, or simply for maintainability? 
   * **What functional part of the code is being changed?** While the summary mentions the affected functions, it could be more explicit about which parts of the codebase are involved (e.g., build system, toolchain scripts). 
   
   **Impact:**
   
   * While stating "There should be no impact" is a good start, it's helpful to be a bit more specific for each category.  For example:
       * **Impact on user:**  "No changes to user-facing functionality or APIs."
       * **Impact on build:** "Build process remains the same, but may be slightly faster due to shallow clones." 
       * **Impact on compatibility:** "Should be fully backward compatible."
   
   **Testing:**
   
   * **Relying solely on CI is insufficient.** While CI is essential, it's crucial to provide some evidence of local testing as well. This helps demonstrate that you've personally verified the changes and that they function as intended.
   * **Include basic details about your local setup:** Briefly mention the host OS, target architecture, and a couple of configurations you tested.
   
   **In summary, the PR provides a good starting point but would benefit from slightly more detail and evidence of local testing to ensure clarity and completeness.** 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] ci/platforms/msys2.sh: update esptool version and switch Wget to cURL tool [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13608:
URL: https://github.com/apache/nuttx/pull/13608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org