You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/07 11:06:27 UTC
[GitHub] [airflow] potiuk opened a new pull request #22046: Relax typing-extensions limits after dask has been updated
potiuk opened a new pull request #22046:
URL: https://github.com/apache/airflow/pull/22046
Some of the tests failed with typing extensions above 4.
This PR attempts to relax the limits and fix all the failures.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22046: Relax typing-extensions limits after dask has been updated
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060614309
Fixing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22046: Relax typing-extensions limits after dask has been updated
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060575037
I **think** some tests will fail - let's see :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22046: Update limits of dependencies after dask test disabling
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22046:
URL: https://github.com/apache/airflow/pull/22046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22046: Relax typing-extensions limits after dask has been updated
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060613848
Not exactly those that I expected :) but errors they are :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22046: Relax typing-extensions limits after dask has been updated
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060573271
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22046: Update limits of dependencies after dask test disabling
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060700191
I just pushed the constraint fix (did not push it previously) so it should be good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22046: Update limits of dependencies after dask test disabling
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22046:
URL: https://github.com/apache/airflow/pull/22046#issuecomment-1060657254
Hey @uranusjr - you might want to re-review this one. Turned out that the errors are coming from (released 5 hrs ago) 0.19.0 version of `responses` library that breaks S3 mocking. Issue created in https://github.com/getsentry/responses/issues/511 (with super-easily reproducible path thanks to our CI harness).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org